| Message ID | 20211013034128.2094426-3-boon.leong.ong@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: dp83867 non-OF and loopback support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Series has a cover letter |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Wed, Oct 13, 2021 at 11:41:28AM +0800, Ong Boon Leong wrote: > From: "Lay, Kuan Loon" <kuan.loon.lay@intel.com> > > TI DP83867 supports loopback enabled using BMCR, so we add > genphy_loopback to the phy driver. > > Tested-by: Clement <clement@intel.com> > Signed-off-by: Lay, Kuan Loon <kuan.loon.lay@intel.com> > Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> > --- > drivers/net/phy/dp83867.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c > index bb4369b75179..af47c62d6e04 100644 > --- a/drivers/net/phy/dp83867.c > +++ b/drivers/net/phy/dp83867.c > @@ -878,6 +878,7 @@ static struct phy_driver dp83867_driver[] = { > > .suspend = genphy_suspend, > .resume = genphy_resume, > + .set_loopback = genphy_loopback, Isn't this already handled in phy_loopback() in drivers/net/phy/phy_device.c? > }, > }; > module_phy_driver(dp83867_driver);
>> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c >> index bb4369b75179..af47c62d6e04 100644 >> --- a/drivers/net/phy/dp83867.c >> +++ b/drivers/net/phy/dp83867.c >> @@ -878,6 +878,7 @@ static struct phy_driver dp83867_driver[] = { >> >> .suspend = genphy_suspend, >> .resume = genphy_resume, >> + .set_loopback = genphy_loopback, > >Isn't this already handled in phy_loopback() in >drivers/net/phy/phy_device.c? > That is right. Thanks.
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index bb4369b75179..af47c62d6e04 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -878,6 +878,7 @@ static struct phy_driver dp83867_driver[] = { .suspend = genphy_suspend, .resume = genphy_resume, + .set_loopback = genphy_loopback, }, }; module_phy_driver(dp83867_driver);