| Message ID | 20211013080456.GC6010@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e79d82643a69df03d59fe47e32619515a83e4969 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: enetc: fix check for allocation failure | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Wed, Oct 13, 2021 at 11:04:56AM +0300, Dan Carpenter wrote: > This was supposed to be a check for if dma_alloc_coherent() failed > but it has a copy and paste bug so it will not work. > > Fixes: fb8629e2cbfc ("net: enetc: add support for software TSO") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com> Thanks a lot. Ioana
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 13 Oct 2021 11:04:56 +0300 you wrote: > This was supposed to be a check for if dma_alloc_coherent() failed > but it has a copy and paste bug so it will not work. > > Fixes: fb8629e2cbfc ("net: enetc: add support for software TSO") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/freescale/enetc/enetc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] net: enetc: fix check for allocation failure https://git.kernel.org/netdev/net-next/c/e79d82643a69 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 09193b478ab3..beecb1a1276e 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1766,8 +1766,10 @@ static int enetc_alloc_txbdr(struct enetc_bdr *txr) txr->bd_count * TSO_HEADER_SIZE, &txr->tso_headers_dma, GFP_KERNEL); - if (err) + if (!txr->tso_headers) { + err = -ENOMEM; goto err_alloc_tso; + } txr->next_to_clean = 0; txr->next_to_use = 0;
This was supposed to be a check for if dma_alloc_coherent() failed but it has a copy and paste bug so it will not work. Fixes: fb8629e2cbfc ("net: enetc: add support for software TSO") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)