| Message ID | 20211013081656.16494-1-sreekanth.reddy@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mpi3mr: Fix duplicate device entries when scan through sysfs | expand |
On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote: > When the user scans the devices through 'scan' sysfs using below > command then the user will observe duplicate device entries > in lsscsi command output. > echo "- - -" > /sys/class/scsi_host/host0/scan > > Fix is to set the shost's max_channel to zero. > > Cc: stable@vger.kernel.org #v5.14.11+ Please tag this based on a release of Linus's, or better yet, provide a "Fixes:" commit so that the stable people know exactly where to backport it to. As this is, we do not take patches only for stable kernels... thanks, greg k-h
On Wed, Oct 13, 2021 at 1:53 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote: > > When the user scans the devices through 'scan' sysfs using below > > command then the user will observe duplicate device entries > > in lsscsi command output. > > echo "- - -" > /sys/class/scsi_host/host0/scan > > > > Fix is to set the shost's max_channel to zero. > > > > Cc: stable@vger.kernel.org #v5.14.11+ > > Please tag this based on a release of Linus's, or better yet, provide a > "Fixes:" commit so that the stable people know exactly where to backport > it to. Thanks, Shall I resend the patch with proper "Fixes:" commit ID. > > As this is, we do not take patches only for stable kernels... This fix applies for the mainline kernel as well. Thanks, Sreekanth > > thanks, > > greg k-h
On Wed, Oct 13, 2021 at 09:35:39PM +0530, Sreekanth Reddy wrote: > On Wed, Oct 13, 2021 at 1:53 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote: > > > When the user scans the devices through 'scan' sysfs using below > > > command then the user will observe duplicate device entries > > > in lsscsi command output. > > > echo "- - -" > /sys/class/scsi_host/host0/scan > > > > > > Fix is to set the shost's max_channel to zero. > > > > > > Cc: stable@vger.kernel.org #v5.14.11+ > > > > Please tag this based on a release of Linus's, or better yet, provide a > > "Fixes:" commit so that the stable people know exactly where to backport > > it to. > Thanks, Shall I resend the patch with proper "Fixes:" commit ID. Yes please. > > As this is, we do not take patches only for stable kernels... > This fix applies for the mainline kernel as well. That's good, as that is the only way to get patches accepted :)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index 2197988333fe..3cae8803383b 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -3736,7 +3736,7 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id) shost->max_lun = -1; shost->unique_id = mrioc->id; - shost->max_channel = 1; + shost->max_channel = 0; shost->max_id = 0xFFFFFFFF; if (prot_mask >= 0)
When the user scans the devices through 'scan' sysfs using below command then the user will observe duplicate device entries in lsscsi command output. echo "- - -" > /sys/class/scsi_host/host0/scan Fix is to set the shost's max_channel to zero. Cc: stable@vger.kernel.org #v5.14.11+ Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> --- drivers/scsi/mpi3mr/mpi3mr_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)