| Message ID | 20211003030357.32456-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC | expand |
Hi Randy, On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote: > Geert pointed out that since sound/soc has the soc_dummy_driver for > NO_DMA platforms, it is possible (desirable) to have drivers that > depend on HAS_DMA to alternately depend on COMPILE_TEST. Actually I had never heard about the soc_dummy_driver before ;-) I did know about the dummies in include/linux/dma-mapping.h. > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. COMPILE_TEST > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- > sound/soc/atmel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig > +++ linux-next-20211001/sound/soc/atmel/Kconfig > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC > > config SND_ATMEL_SOC_PDC > bool > + depends on HAS_DMA || COMPILE_TEST > > config SND_ATMEL_SOC_DMA > bool The actual change LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 03.10.2021 06:03, Randy Dunlap wrote: > Geert pointed out that since sound/soc has the soc_dummy_driver for > NO_DMA platforms, it is possible (desirable) to have drivers that > depend on HAS_DMA to alternately depend on COMPILE_TEST. > > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. > > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- > sound/soc/atmel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig > +++ linux-next-20211001/sound/soc/atmel/Kconfig > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC > > config SND_ATMEL_SOC_PDC > bool > + depends on HAS_DMA || COMPILE_TEST SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand the need for this...
Hi Codrin, On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote: > On 03.10.2021 06:03, Randy Dunlap wrote: > > Geert pointed out that since sound/soc has the soc_dummy_driver for > > NO_DMA platforms, it is possible (desirable) to have drivers that > > depend on HAS_DMA to alternately depend on COMPILE_TEST. > > > > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. > > > > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: alsa-devel@alsa-project.org > > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > > --- > > sound/soc/atmel/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig > > +++ linux-next-20211001/sound/soc/atmel/Kconfig > > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC > > > > config SND_ATMEL_SOC_PDC > > bool > > + depends on HAS_DMA || COMPILE_TEST > > SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand > the need for this... Does it work without DMA support? If not, it doesn't make much sense to offer this option to the user, unless the user is compile-testing. Gr{oetje,eeting}s, Geert
On 13.10.2021 11:40, Geert Uytterhoeven wrote: > Hi Codrin, > > On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote: >> On 03.10.2021 06:03, Randy Dunlap wrote: >>> Geert pointed out that since sound/soc has the soc_dummy_driver for >>> NO_DMA platforms, it is possible (desirable) to have drivers that >>> depend on HAS_DMA to alternately depend on COMPILE_TEST. >>> >>> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. >>> >>> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Cc: Liam Girdwood <lgirdwood@gmail.com> >>> Cc: Mark Brown <broonie@kernel.org> >>> Cc: alsa-devel@alsa-project.org >>> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> >>> --- >>> sound/soc/atmel/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig >>> +++ linux-next-20211001/sound/soc/atmel/Kconfig >>> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC >>> >>> config SND_ATMEL_SOC_PDC >>> bool >>> + depends on HAS_DMA || COMPILE_TEST >> >> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand >> the need for this... > > Does it work without DMA support? > If not, it doesn't make much sense to offer this option to the user, unless > the user is compile-testing. it is using a Peripheral DMA controller, that is mapped in SSC's address space and is not using the DMA engine. I see that HAS_DMA is needed for the DMA mapping API, which we use, so I guess we do depend on it. That being said: Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Thanks!
--- linux-next-20211001.orig/sound/soc/atmel/Kconfig +++ linux-next-20211001/sound/soc/atmel/Kconfig @@ -11,6 +11,7 @@ if SND_ATMEL_SOC config SND_ATMEL_SOC_PDC bool + depends on HAS_DMA || COMPILE_TEST config SND_ATMEL_SOC_DMA bool
Geert pointed out that since sound/soc has the soc_dummy_driver for NO_DMA platforms, it is possible (desirable) to have drivers that depend on HAS_DMA to alternately depend on COMPILE_TEST. This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> --- sound/soc/atmel/Kconfig | 1 + 1 file changed, 1 insertion(+)