| Message ID | 20211008012524.481877-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | | expand |
On Fri, Oct 8, 2021 at 3:25 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > In 2019 (in kernel 5.4) spmi-gpio and ssbi-gpio drivers were converted > to hierarchical IRQ helpers, however MPP drivers were not converted at > that moment. Complete this by converting MPP drivers. > > Changes since v2: > - Add patches fixing/updating mpps nodes in the existing device trees Thanks a *lot* for being thorough and fixing all this properly! I am happy to apply the pinctrl portions to the pinctrl tree, I'm uncertain about Rob's syntax checker robot here, are there real problems? Sometimes it complains about things being changed in the DTS files at the same time. I could apply all of this (including DTS changes) to an immutable branch and offer to Bjorn if he is fine with the patches and the general approach. Yours, Linus Walleij
On Wed, 13 Oct 2021 at 02:59, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Oct 8, 2021 at 3:25 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > In 2019 (in kernel 5.4) spmi-gpio and ssbi-gpio drivers were converted > > to hierarchical IRQ helpers, however MPP drivers were not converted at > > that moment. Complete this by converting MPP drivers. > > > > Changes since v2: > > - Add patches fixing/updating mpps nodes in the existing device trees > > Thanks a *lot* for being thorough and fixing all this properly! > > I am happy to apply the pinctrl portions to the pinctrl tree, I'm > uncertain about Rob's syntax checker robot here, are there real > problems? Sometimes it complains about things being changed > in the DTS files at the same time. Rob's checker reports issue that are being fixed by respective patches. I think I've updated all dts entries for the mpp devices tree nodes. > I could apply all of this (including DTS changes) to an immutable > branch and offer to Bjorn if he is fine with the patches and > the general approach. I'm fine with either approach.
On Wed, Oct 13, 2021 at 5:46 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > On Wed, 13 Oct 2021 at 02:59, Linus Walleij <linus.walleij@linaro.org> wrote: > > I am happy to apply the pinctrl portions to the pinctrl tree, I'm > > uncertain about Rob's syntax checker robot here, are there real > > problems? Sometimes it complains about things being changed > > in the DTS files at the same time. > > Rob's checker reports issue that are being fixed by respective > patches. I think I've updated all dts entries for the mpp devices tree > nodes. > > > I could apply all of this (including DTS changes) to an immutable > > branch and offer to Bjorn if he is fine with the patches and > > the general approach. > > I'm fine with either approach. Let's see what Bjorn says, if nothing happens poke me again and I'll create an immutable branch and merge it. Yours, Linus Walleij
On Tue 12 Oct 18:59 CDT 2021, Linus Walleij wrote: > On Fri, Oct 8, 2021 at 3:25 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > In 2019 (in kernel 5.4) spmi-gpio and ssbi-gpio drivers were converted > > to hierarchical IRQ helpers, however MPP drivers were not converted at > > that moment. Complete this by converting MPP drivers. > > > > Changes since v2: > > - Add patches fixing/updating mpps nodes in the existing device trees > > Thanks a *lot* for being thorough and fixing all this properly! > > I am happy to apply the pinctrl portions to the pinctrl tree, I'm > uncertain about Rob's syntax checker robot here, are there real > problems? Sometimes it complains about things being changed > in the DTS files at the same time. > > I could apply all of this (including DTS changes) to an immutable > branch and offer to Bjorn if he is fine with the patches and > the general approach. > I like the driver changes and I'm wrapping up a second pull for the dts pieces in the coming few days. So if you're happy to take the driver patches I'll include the DT changes for 5.16 as well. Thanks, Bjorn
On Sun, Oct 17, 2021 at 6:54 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > I like the driver changes and I'm wrapping up a second pull for the dts > pieces in the coming few days. So if you're happy to take the driver > patches I'll include the DT changes for 5.16 as well. OK let's do like that. I'll queue the binding changes and driver changes so we finally get this fixed up. Yours, Linus Walleij
I queued thes patches in the pinctrl tree for v5.16: On Fri, Oct 8, 2021 at 3:25 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > dt-bindings: pinctrl: qcom,pmic-mpp: Convert qcom pmic mpp bindings to YAML > pinctrl: qcom: ssbi-mpp: hardcode IRQ counts > pinctrl: qcom: ssbi-mpp: add support for hierarchical IRQ chip > pinctrl: qcom: spmi-mpp: hardcode IRQ counts > pinctrl: qcom: spmi-mpp: add support for hierarchical IRQ chip > dt-bindings: pinctrl: qcom,pmic-mpp: switch to #interrupt-cells Any breakages will be fixed when Bjorn applies the DTS changes to his tree. I wonder about the MFD patch, maybe Lee can expedite merging that too or ACK it for Bjorn to merge with the remainders. Yours, Linus Walleij
On Fri, 8 Oct 2021 04:24:59 +0300, Dmitry Baryshkov wrote: > In 2019 (in kernel 5.4) spmi-gpio and ssbi-gpio drivers were converted > to hierarchical IRQ helpers, however MPP drivers were not converted at > that moment. Complete this by converting MPP drivers. > > Changes since v2: > - Add patches fixing/updating mpps nodes in the existing device trees > > [...] Applied, thanks! [03/25] ARM: dts: qcom-apq8064: add gpio-ranges to mpps nodes commit: 9be51f0b16ef83208fbfdc42fe59a622b6beee4c [04/25] ARM: dts: qcom-msm8660: add gpio-ranges to mpps nodes commit: cd1049b631d05ad25b7976cf67144277598e72f2 [05/25] ARM: dts: qcom-pm8841: add gpio-ranges to mpps nodes commit: 6a91e584a3a0a247f836f063cbd3d99b1babaf4c [06/25] ARM: dts: qcom-pm8941: add gpio-ranges to mpps nodes commit: 72af8d006b68cb88ae618d812b1053e59b06fe56 [07/25] ARM: dts: qcom-pma8084: add gpio-ranges to mpps nodes commit: 50ec4abed12cd0d5d34656330bb82192d607b3b7 [08/25] ARM: dts: qcom-mdm9615: add gpio-ranges to mpps node, fix its name commit: 7cf05e3b457b4d0eea385ad0acec327ee0adc5a1 [09/25] ARM: dts: qcom-apq8060-dragonboard: fix mpps state names commit: 636396efe303345cba6b0084b3228cf861d22e36 [18/25] ARM: dts: qcom-apq8064: add interrupt controller properties commit: 216f41938d669e7949964c181350cb61b4fdda03 [19/25] ARM: dts: qcom-mdm9615: add interrupt controller properties commit: f574aa0b12403dd0f4bef366199bfba860188086 [20/25] ARM: dts: qcom-msm8660: add interrupt controller properties commit: 789a247a3f10985ddae58a975e2550a35388ca52 [21/25] ARM: dts: qcom-pm8841: add interrupt controller properties commit: 3dca61a70c0453ea02089059d9d435a7b9b104ce [22/25] ARM: dts: qcom-pm8941: add interrupt controller properties commit: 9fb04774f3436f93075b80870fd94e2e68f8bf04 [23/25] ARM: dts: qcom-pma8084: add interrupt controller properties commit: a7fe01561e6cda173b1fffb1c8552040933e7588 Best regards,
In 2019 (in kernel 5.4) spmi-gpio and ssbi-gpio drivers were converted to hierarchical IRQ helpers, however MPP drivers were not converted at that moment. Complete this by converting MPP drivers. Changes since v2: - Add patches fixing/updating mpps nodes in the existing device trees Changes since v1: - Drop the interrupt-controller from initial schema conversion - Add gpio-line-names to the qcom,pmic-mpp schema and to the example The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: https://git.linaro.org/people/dmitry.baryshkov/kernel.git spmi-mpp for you to fetch changes up to 9bccc31fc5cec98f26ca639a2ee21a9831efe1de: arm64: dts: qcom: pm8994: add interrupt controller properties (2021-10-08 04:19:33 +0300) ---------------------------------------------------------------- Dmitry Baryshkov (25): dt-bindings: pinctrl: qcom,pmic-mpp: Convert qcom pmic mpp bindings to YAML dt-bindings: mfd: qcom-pm8xxx: add missing child nodes ARM: dts: qcom-apq8064: add gpio-ranges to mpps nodes ARM: dts: qcom-msm8660: add gpio-ranges to mpps nodes ARM: dts: qcom-pm8841: add gpio-ranges to mpps nodes ARM: dts: qcom-pm8941: add gpio-ranges to mpps nodes ARM: dts: qcom-pma8084: add gpio-ranges to mpps nodes ARM: dts: qcom-mdm9615: add gpio-ranges to mpps node, fix its name ARM: dts: qcom-apq8060-dragonboard: fix mpps state names arm64: dts: qcom: pm8916: fix mpps device tree node arm64: dts: qcom: pm8994: fix mpps device tree node arm64: dts: qcom: apq8016-sbc: fix mpps state names pinctrl: qcom: ssbi-mpp: hardcode IRQ counts pinctrl: qcom: ssbi-mpp: add support for hierarchical IRQ chip pinctrl: qcom: spmi-mpp: hardcode IRQ counts pinctrl: qcom: spmi-mpp: add support for hierarchical IRQ chip dt-bindings: pinctrl: qcom,pmic-mpp: switch to #interrupt-cells ARM: dts: qcom-apq8064: add interrupt controller properties ARM: dts: qcom-mdm9615: add interrupt controller properties ARM: dts: qcom-msm8660: add interrupt controller properties ARM: dts: qcom-pm8841: add interrupt controller properties ARM: dts: qcom-pm8941: add interrupt controller properties ARM: dts: qcom-pma8084: add interrupt controller properties arm64: dts: qcom: pm8916: add interrupt controller properties arm64: dts: qcom: pm8994: add interrupt controller properties .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 12 ++ .../devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 187 -------------------- .../devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 188 +++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 4 +- arch/arm/boot/dts/qcom-apq8064.dtsi | 23 +-- arch/arm/boot/dts/qcom-mdm9615.dtsi | 12 +- arch/arm/boot/dts/qcom-msm8660.dtsi | 17 +- arch/arm/boot/dts/qcom-pm8841.dtsi | 7 +- arch/arm/boot/dts/qcom-pm8941.dtsi | 11 +- arch/arm/boot/dts/qcom-pma8084.dtsi | 11 +- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 +- arch/arm64/boot/dts/qcom/pm8916.dtsi | 9 +- arch/arm64/boot/dts/qcom/pm8994.dtsi | 13 +- drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 111 ++++++++---- drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 133 +++++++++++---- 15 files changed, 414 insertions(+), 328 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml