[RFT,v3,0/2] clk: samsung: add common support for CPU clocks

Message

William McVicker Oct. 13, 2021, 10:10 p.m. UTC

These two patches were originally a part of the series [1]. They add
support to the common samsung clock driver to parse and register the
CPU clocks when provided. This allows for the samsung clock drivers to
simply provide a `struct samsung_cpu_clock` to `struct samsung_cmu_info`
and then call samsung_cmu_register_one(). With this new support, we can
now get rid of the custom apollo and atlas CLK_OF_DECLARE init functions.

Since I don't have the hardware to test these, I'm including the RFT tag
to try and get help testing and verifying these.

[1] https://lore.kernel.org/all/[e-mail]/

Will McVicker (2):
  [RFT] clk: samsung: add support for CPU clocks
  [RFT] clk: samsung: exynos5433: update apollo and atlas clock probing

 drivers/clk/samsung/clk-cpu.c        |  26 ++++++
 drivers/clk/samsung/clk-exynos5433.c | 120 +++++++++++----------------
 drivers/clk/samsung/clk.c            |   2 +
 drivers/clk/samsung/clk.h            |  26 ++++++
 4 files changed, 102 insertions(+), 72 deletions(-)

Comments

Marek Szyprowski Oct. 14, 2021, 8:33 a.m. UTC | #1

On 14.10.2021 00:10, Will McVicker wrote:
> These two patches were originally a part of the series [1]. They add
> support to the common samsung clock driver to parse and register the
> CPU clocks when provided. This allows for the samsung clock drivers to
> simply provide a `struct samsung_cpu_clock` to `struct samsung_cmu_info`
> and then call samsung_cmu_register_one(). With this new support, we can
> now get rid of the custom apollo and atlas CLK_OF_DECLARE init functions.
>
> Since I don't have the hardware to test these, I'm including the RFT tag
> to try and get help testing and verifying these.
>
> [1] https://protect2.fireeye.com/v1/url?k=91329df7-cea9a478-913316b8-0cc47a31307c-8e0b8e6442100c5a&q=1&e=50af1e33-8bdf-429f-9e54-434d425998d6&u=https%3A%2F%2Flore.kernel.org%2Fall%2F20210928235635.1348330-4-willmcvicker%40google.com%2F

Works fine on my Exynos5433 TM2e test board.

Tested-by: Marek Szyprowski <[e-mail]>

> Will McVicker (2):
>    [RFT] clk: samsung: add support for CPU clocks
>    [RFT] clk: samsung: exynos5433: update apollo and atlas clock probing
>
>   drivers/clk/samsung/clk-cpu.c        |  26 ++++++
>   drivers/clk/samsung/clk-exynos5433.c | 120 +++++++++++----------------
>   drivers/clk/samsung/clk.c            |   2 +
>   drivers/clk/samsung/clk.h            |  26 ++++++
>   4 files changed, 102 insertions(+), 72 deletions(-)
>
Best regards

William McVicker Oct. 14, 2021, 7:46 p.m. UTC | #2

On Thu, Oct 14, 2021 at 1:33 AM Marek Szyprowski
<[e-mail]> wrote:
>
> On 14.10.2021 00:10, Will McVicker wrote:
> > These two patches were originally a part of the series [1]. They add
> > support to the common samsung clock driver to parse and register the
> > CPU clocks when provided. This allows for the samsung clock drivers to
> > simply provide a `struct samsung_cpu_clock` to `struct samsung_cmu_info`
> > and then call samsung_cmu_register_one(). With this new support, we can
> > now get rid of the custom apollo and atlas CLK_OF_DECLARE init functions.
> >
> > Since I don't have the hardware to test these, I'm including the RFT tag
> > to try and get help testing and verifying these.
> >
> > [1] https://protect2.fireeye.com/v1/url?k=91329df7-cea9a478-913316b8-0cc47a31307c-8e0b8e6442100c5a&q=1&e=50af1e33-8bdf-429f-9e54-434d425998d6&u=https%3A%2F%2Flore.kernel.org%2Fall%2F20210928235635.1348330-4-willmcvicker%40google.com%2F
>
> Works fine on my Exynos5433 TM2e test board.
>
> Tested-by: Marek Szyprowski <[e-mail]>

Thanks for testing!

>
> > Will McVicker (2):
> >    [RFT] clk: samsung: add support for CPU clocks
> >    [RFT] clk: samsung: exynos5433: update apollo and atlas clock probing
> >
> >   drivers/clk/samsung/clk-cpu.c        |  26 ++++++
> >   drivers/clk/samsung/clk-exynos5433.c | 120 +++++++++++----------------
> >   drivers/clk/samsung/clk.c            |   2 +
> >   drivers/clk/samsung/clk.h            |  26 ++++++
> >   4 files changed, 102 insertions(+), 72 deletions(-)
> >
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>