diff mbox series

KVM: kvm_stat: do not show halt_wait_ns

Message ID 20211006121724.4154-1-borntraeger@de.ibm.com (mailing list archive)
State New, archived
Headers show
Series KVM: kvm_stat: do not show halt_wait_ns | expand

Commit Message

Christian Borntraeger Oct. 6, 2021, 12:17 p.m. UTC
Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
counters"), we should not show timer values in kvm_stat. Remove the new
halt_wait_ns.

Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
Cc: Jing Zhang <jingzhangos@google.com>
Cc: Stefan Raspl <raspl@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 tools/kvm/kvm_stat/kvm_stat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Raspl Oct. 6, 2021, 1:15 p.m. UTC | #1
On 10/6/21 14:17, Christian Borntraeger wrote:
> Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
> counters"), we should not show timer values in kvm_stat. Remove the new
> halt_wait_ns.
> 
> Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
> Cc: Jing Zhang <jingzhangos@google.com>
> Cc: Stefan Raspl <raspl@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

Reviewed-by: Stefan Raspl <raspl@linux.ibm.com>
Paolo Bonzini Oct. 15, 2021, 9:07 a.m. UTC | #2
On 06/10/21 14:17, Christian Borntraeger wrote:
> Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
> counters"), we should not show timer values in kvm_stat. Remove the new
> halt_wait_ns.
> 
> Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
> Cc: Jing Zhang <jingzhangos@google.com>
> Cc: Stefan Raspl <raspl@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>   tools/kvm/kvm_stat/kvm_stat | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index b0bf56c5f120..5a5bd74f55bd 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -742,7 +742,7 @@ class DebugfsProvider(Provider):
>           The fields are all available KVM debugfs files
>   
>           """
> -        exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns']
> +        exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns', 'halt_wait_ns']
>           fields = [field for field in self.walkdir(PATH_DEBUGFS_KVM)[2]
>                     if field not in exempt_list]
>   
> 

Applied, thanks.

Paolo
diff mbox series

Patch

diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index b0bf56c5f120..5a5bd74f55bd 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -742,7 +742,7 @@  class DebugfsProvider(Provider):
         The fields are all available KVM debugfs files
 
         """
-        exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns']
+        exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns', 'halt_wait_ns']
         fields = [field for field in self.walkdir(PATH_DEBUGFS_KVM)[2]
                   if field not in exempt_list]