| Message ID | 20211016153244.24353-2-verdre@v0yd.nl (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | A few more cleanups and fixes for mwifiex | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Sat, 2021-10-16 at 17:32 +0200, Jonas Dreßler wrote: > It's not an error if someone chooses to put their computer to sleep, not > wanting it to wake up because the person next door has just discovered > what a magic packet is. So change the loglevel of this annoying message > from ERROR to INFO. > > Signed-off-by: Jonas Dreßler <verdre@v0yd.nl> > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index ef697572a293..987558c4fc79 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -3492,7 +3492,7 @@ static int mwifiex_cfg80211_suspend(struct wiphy *wiphy, > } > > if (!wowlan) { > - mwifiex_dbg(adapter, ERROR, > + mwifiex_dbg(adapter, INFO, > "None of the WOWLAN triggers enabled\n"); None of these are have a loglevel of KERN_ERR, all of these are logged at KERN_INFO. What I don't understand is why mwifiex_dbg is using KERN_INFO at all and not KERN_DEBUG. [] drivers/net/wireless/marvell/mwifiex/main.h:#define mwifiex_dbg(adapter, mask, fmt, ...) \ drivers/net/wireless/marvell/mwifiex/main.h- _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) [] drivers/net/wireless/marvell/mwifiex/main.c:void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask, drivers/net/wireless/marvell/mwifiex/main.c- const char *fmt, ...) drivers/net/wireless/marvell/mwifiex/main.c-{ drivers/net/wireless/marvell/mwifiex/main.c- struct va_format vaf; drivers/net/wireless/marvell/mwifiex/main.c- va_list args; drivers/net/wireless/marvell/mwifiex/main.c- drivers/net/wireless/marvell/mwifiex/main.c- if (!(adapter->debug_mask & mask)) drivers/net/wireless/marvell/mwifiex/main.c- return; drivers/net/wireless/marvell/mwifiex/main.c- drivers/net/wireless/marvell/mwifiex/main.c- va_start(args, fmt); drivers/net/wireless/marvell/mwifiex/main.c- drivers/net/wireless/marvell/mwifiex/main.c- vaf.fmt = fmt; drivers/net/wireless/marvell/mwifiex/main.c- vaf.va = &args; drivers/net/wireless/marvell/mwifiex/main.c- drivers/net/wireless/marvell/mwifiex/main.c- if (adapter->dev) drivers/net/wireless/marvell/mwifiex/main.c- dev_info(adapter->dev, "%pV", &vaf); drivers/net/wireless/marvell/mwifiex/main.c- else drivers/net/wireless/marvell/mwifiex/main.c- pr_info("%pV", &vaf); drivers/net/wireless/marvell/mwifiex/main.c- drivers/net/wireless/marvell/mwifiex/main.c- va_end(args); drivers/net/wireless/marvell/mwifiex/main.c-} drivers/net/wireless/marvell/mwifiex/main.c:EXPORT_SYMBOL_GPL(_mwifiex_dbg);
Jonas Dreßler <verdre@v0yd.nl> wrote: > It's not an error if someone chooses to put their computer to sleep, not > wanting it to wake up because the person next door has just discovered > what a magic packet is. So change the loglevel of this annoying message > from ERROR to INFO. > > Signed-off-by: Jonas Dreßler <verdre@v0yd.nl> 5 patches applied to wireless-drivers-next.git, thanks. 03893e93aff8 mwifiex: Don't log error on suspend if wake-on-wlan is disabled fd7f8c321b78 mwifiex: Log an error on command failure during key-material upload a8a8fc7b2a71 mwifiex: Fix an incorrect comment cc8a8bc37466 mwifiex: Send DELBA requests according to spec 5943a864fe84 mwifiex: Deactive host sleep using HSCFG after it was activated manually
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index ef697572a293..987558c4fc79 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -3492,7 +3492,7 @@ static int mwifiex_cfg80211_suspend(struct wiphy *wiphy, } if (!wowlan) { - mwifiex_dbg(adapter, ERROR, + mwifiex_dbg(adapter, INFO, "None of the WOWLAN triggers enabled\n"); ret = 0; goto done;
It's not an error if someone chooses to put their computer to sleep, not wanting it to wake up because the person next door has just discovered what a magic packet is. So change the loglevel of this annoying message from ERROR to INFO. Signed-off-by: Jonas Dreßler <verdre@v0yd.nl> --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)