mbox series

[v2,0/2] Add memcg accounting to Arm KVM

Message ID 20210907123112.10232-1-justin.he@arm.com (mailing list archive)
Headers show
Series Add memcg accounting to Arm KVM | expand

Message

Jia He Sept. 7, 2021, 12:31 p.m. UTC
Inspired by what had been done by X86 kvm and kvm common codes, it would
be better to make arm64 kvm consistent with them.

The memory allocations of VM scope should be charged into VM process.
Hence change the allocation flag from GFP_KERNEL to GFP_KERNEL_ACCOUNT.

There remain some GFP_KERNEL unchanged since they are global allocations,
instead of VM scope.

Changes:
v2: address a few comments from Marc Zyngier, including redundant
    GFP_KERNEL, incorrect memcg accounting and variable type   
v1: https://lkml.org/lkml/2021/9/2/649

Jia He (2):
  KVM: arm64: vgic: Add memcg accounting to vgic allocations
  KVM: arm64: Add memcg accounting to KVM allocations

 arch/arm64/kvm/arm.c               |  6 ++++--
 arch/arm64/kvm/mmu.c               |  2 +-
 arch/arm64/kvm/pmu-emul.c          |  2 +-
 arch/arm64/kvm/reset.c             |  2 +-
 arch/arm64/kvm/vgic/vgic-init.c    |  2 +-
 arch/arm64/kvm/vgic/vgic-irqfd.c   |  2 +-
 arch/arm64/kvm/vgic/vgic-its.c     | 14 +++++++-------
 arch/arm64/kvm/vgic/vgic-mmio-v3.c |  2 +-
 arch/arm64/kvm/vgic/vgic-v4.c      |  2 +-
 9 files changed, 18 insertions(+), 16 deletions(-)

Comments

Marc Zyngier Oct. 17, 2021, 10:30 a.m. UTC | #1
On Tue, 7 Sep 2021 20:31:10 +0800, Jia He wrote:
> Inspired by what had been done by X86 kvm and kvm common codes, it would
> be better to make arm64 kvm consistent with them.
> 
> The memory allocations of VM scope should be charged into VM process.
> Hence change the allocation flag from GFP_KERNEL to GFP_KERNEL_ACCOUNT.
> 
> There remain some GFP_KERNEL unchanged since they are global allocations,
> instead of VM scope.
> 
> [...]

Applied to next, thanks!

[1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations
      commit: 3ef231670b9e9001316a426e794b2c74b8f6b4f6
[2/2] KVM: arm64: Add memcg accounting to KVM allocations
      commit: 115bae923ac8bb29ee635e0ed6b4d5a3eec9371e

Cheers,

	M.