| Message ID | 20211018033102.1813058-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a04310edcd00d6014126483a2d8cd95b4786db25 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() | expand |
> -----Original Message----- > From: Yang Yingliang <yangyingliang@huawei.com> > Sent: Monday, October 18, 2021 11:31 AM > To: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-wireless@vger.kernel.org > Cc: Pkshih <pkshih@realtek.com>; kuba@kernel.org; davem@davemloft.net; kvalo@codeaurora.org > Subject: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() > > Fix the return value check which testing the wrong variable > in rtw89_cam_send_sec_key_cmd(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > --- > drivers/net/wireless/realtek/rtw89/cam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtw89/cam.c > b/drivers/net/wireless/realtek/rtw89/cam.c > index c1e8c76c6aca..ad7a8155dbed 100644 > --- a/drivers/net/wireless/realtek/rtw89/cam.c > +++ b/drivers/net/wireless/realtek/rtw89/cam.c > @@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev, > return 0; > > ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true); > - if (!skb) { > + if (!ext_skb) { > rtw89_err(rtwdev, "failed to get ext sec key command\n"); > return -ENOMEM; > } > -- > 2.25.1 > > ------Please consider the environment before printing this e-mail.
Yang Yingliang <yangyingliang@huawei.com> wrote: > Fix the return value check which testing the wrong variable > in rtw89_cam_send_sec_key_cmd(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> rtw89 patches are applied wireless-drivers-next, not net-next. rtw89 is not even in net-next yet.
Hi, On 2021/10/18 20:16, Kalle Valo wrote: > Yang Yingliang <yangyingliang@huawei.com> wrote: > >> Fix the return value check which testing the wrong variable >> in rtw89_cam_send_sec_key_cmd(). >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > rtw89 patches are applied wireless-drivers-next, not net-next. rtw89 is not > even in net-next yet. It should be -next. Thanks, Yang >
Yang Yingliang <yangyingliang@huawei.com> wrote: > Fix the return value check which testing the wrong variable > in rtw89_cam_send_sec_key_cmd(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers-next.git, thanks. a04310edcd00 rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
diff --git a/drivers/net/wireless/realtek/rtw89/cam.c b/drivers/net/wireless/realtek/rtw89/cam.c index c1e8c76c6aca..ad7a8155dbed 100644 --- a/drivers/net/wireless/realtek/rtw89/cam.c +++ b/drivers/net/wireless/realtek/rtw89/cam.c @@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev, return 0; ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true); - if (!skb) { + if (!ext_skb) { rtw89_err(rtwdev, "failed to get ext sec key command\n"); return -ENOMEM; }
Fix the return value check which testing the wrong variable in rtw89_cam_send_sec_key_cmd(). Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/wireless/realtek/rtw89/cam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)