mbox series

[v4,00/10] regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema

Message ID 20211008113723.134648-1-krzysztof.kozlowski@canonical.com (mailing list archive)
Headers show
Series regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema | expand

Message

Krzysztof Kozlowski Oct. 8, 2021, 11:37 a.m. UTC
Hi All,

Changes since v2
================
1. Add Stephen's and Rob's tags.
2. Correct inb-supply description in patch 10/10.

Changes since v2
================
1. Add Rob's tags.
2. Remove "regulator-name" from properties (all regulator dtschema).
3. Move "unevaluatedProperties" higher to make code easier to read (all regulator dtschema).
4. Add ref-type to op-mode property (patch 6: s5m8767 regulators).

Changes since v1
================
1. Drop DTS patches - applied.
2. Fully remove bindings/regulator/samsung,s5m8767.txt .
3. Minor subject reformatting and few typos in text.


Intro
=====
This patchset converts all devicetree bindings of Samsung S2M and S5M
PMIC devices from txt to dtschema.

It includes also two fixes because later conversion depends on it
(contextually).


Merging/dependencies
====================
1. Regulator related binding changes depend on first two commits (the
   fixes), because of context.
2. The mfd bindings depend on clock and regulator bindings.

The fixes and bindings changes (patches 1-10) should go via the same
tree.  For example regulator or mfd tree.

Another alternative is that regulator patches (1-2, 4-6) go via Mark who
later gives MFD a stable branch/tag to pull. Then the clock and MFD
bindings would go on top via MFD tree. Or any other setup you would like
to have.


Overview of devices
===================
Essentially all Samsung S2M and S5M PMICs are very similar devices. They
provide the same functionality: regulators, RTC, 2 or 3 clocks and main
power management (e.g. power cut to SoC).

The differences are mostly in registers layout and number of regulators.

The drivers are built around one common part, mfd/sec-core.c, and share
some drivers between devices:
1. MFD sec-core for all devices,
1. one clock driver for most of devices,
2. one RTC driver for all devices,
3. three regulator drivers.

The regulator drivers were implementing slightly different features,
therefore one regulator binding for all devices does not make much
sense.  However the clock device binding can be shared.

The final dtschema bindings try to implement this - share only the clock
bindings.

Best regards,
Krzysztof

Krzysztof Kozlowski (10):
  regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS
    is disabled
  regulator: dt-bindings: samsung,s5m8767: correct
    s5m8767,pmic-buck-default-dvs-idx property
  dt-bindings: clock: samsung,s2mps11: convert to dtschema
  regulator: dt-bindings: samsung,s2m: convert to dtschema
  regulator: dt-bindings: samsung,s2mpa01: convert to dtschema
  regulator: dt-bindings: samsung,s5m8767: convert to dtschema
  dt-bindings: mfd: samsung,s2mps11: convert to dtschema
  dt-bindings: mfd: samsung,s2mpa01: convert to dtschema
  dt-bindings: mfd: samsung,s5m8767: convert to dtschema
  dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies

 .../bindings/clock/samsung,s2mps11.txt        |  49 ---
 .../bindings/clock/samsung,s2mps11.yaml       |  45 +++
 .../bindings/mfd/samsung,s2mpa01.yaml         |  91 ++++++
 .../bindings/mfd/samsung,s2mps11.yaml         | 267 +++++++++++++++
 .../bindings/mfd/samsung,s5m8767.yaml         | 307 ++++++++++++++++++
 .../bindings/mfd/samsung,sec-core.txt         |  86 -----
 .../bindings/regulator/samsung,s2mpa01.txt    |  79 -----
 .../bindings/regulator/samsung,s2mpa01.yaml   |  62 ++++
 .../bindings/regulator/samsung,s2mps11.txt    | 102 ------
 .../bindings/regulator/samsung,s2mps11.yaml   |  44 +++
 .../bindings/regulator/samsung,s2mps13.yaml   |  44 +++
 .../bindings/regulator/samsung,s2mps14.yaml   |  44 +++
 .../bindings/regulator/samsung,s2mps15.yaml   |  44 +++
 .../bindings/regulator/samsung,s2mpu02.yaml   |  44 +++
 .../bindings/regulator/samsung,s5m8767.txt    | 145 ---------
 .../bindings/regulator/samsung,s5m8767.yaml   |  74 +++++
 MAINTAINERS                                   |   9 +-
 drivers/regulator/s5m8767.c                   |  21 +-
 18 files changed, 1080 insertions(+), 477 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
 create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps11.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps11.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps13.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps14.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps15.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpu02.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml

Comments

Mark Brown Oct. 8, 2021, 6:54 p.m. UTC | #1
On Fri, Oct 08, 2021 at 01:37:12PM +0200, Krzysztof Kozlowski wrote:

> This patchset converts all devicetree bindings of Samsung S2M and S5M
> PMIC devices from txt to dtschema.

The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:

  Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/s2m_s5m_dtschema

for you to fetch changes up to fab58debc137f66cf97f60c8471ff2f1e3e1b44b:

  regulator: dt-bindings: samsung,s5m8767: convert to dtschema (2021-10-08 17:24:37 +0100)

----------------------------------------------------------------
regulator/clock: Convert the s2m and s5m DT bindings to schema

Tagged to allow further bindings to rely on these.

----------------------------------------------------------------
Krzysztof Kozlowski (6):
      regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS is disabled
      regulator: dt-bindings: samsung,s5m8767: correct s5m8767,pmic-buck-default-dvs-idx property
      dt-bindings: clock: samsung,s2mps11: convert to dtschema
      regulator: dt-bindings: samsung,s2m: convert to dtschema
      regulator: dt-bindings: samsung,s2mpa01: convert to dtschema
      regulator: dt-bindings: samsung,s5m8767: convert to dtschema

 .../devicetree/bindings/clock/samsung,s2mps11.txt  |  49 -------
 .../devicetree/bindings/clock/samsung,s2mps11.yaml |  45 +++++++
 .../bindings/regulator/samsung,s2mpa01.txt         |  79 -----------
 .../bindings/regulator/samsung,s2mpa01.yaml        |  62 +++++++++
 .../bindings/regulator/samsung,s2mps11.txt         | 102 ---------------
 .../bindings/regulator/samsung,s2mps11.yaml        |  44 +++++++
 .../bindings/regulator/samsung,s2mps13.yaml        |  44 +++++++
 .../bindings/regulator/samsung,s2mps14.yaml        |  44 +++++++
 .../bindings/regulator/samsung,s2mps15.yaml        |  44 +++++++
 .../bindings/regulator/samsung,s2mpu02.yaml        |  44 +++++++
 .../bindings/regulator/samsung,s5m8767.txt         | 145 ---------------------
 .../bindings/regulator/samsung,s5m8767.yaml        |  74 +++++++++++
 MAINTAINERS                                        |   6 +-
 drivers/regulator/s5m8767.c                        |  21 ++-
 14 files changed, 413 insertions(+), 390 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
 create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps11.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps11.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps13.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps14.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps15.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpu02.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
Mark Brown Oct. 8, 2021, 6:54 p.m. UTC | #2
From: Mark Brown <broonie@kernel.org>

On Fri, 8 Oct 2021 13:37:12 +0200, Krzysztof Kozlowski wrote:
> Changes since v2
> ================
> 1. Add Stephen's and Rob's tags.
> 2. Correct inb-supply description in patch 10/10.
> 
> Changes since v2
> ================
> 1. Add Rob's tags.
> 2. Remove "regulator-name" from properties (all regulator dtschema).
> 3. Move "unevaluatedProperties" higher to make code easier to read (all regulator dtschema).
> 4. Add ref-type to op-mode property (patch 6: s5m8767 regulators).
> 
> [...]

Applied, thanks!

[01/10] regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS is disabled
        commit: b16bef60a9112b1e6daf3afd16484eb06e7ce792
[02/10] regulator: dt-bindings: samsung,s5m8767: correct s5m8767,pmic-buck-default-dvs-idx property
        commit: a7fda04bc9b6ad9da8e19c9e6e3b1dab773d068a
[03/10] dt-bindings: clock: samsung,s2mps11: convert to dtschema
        commit: 1790cd3510cbd1f3f6217e5d9315f6dee369a690
[04/10] regulator: dt-bindings: samsung,s2m: convert to dtschema
        commit: ea98b9eba05ca01f9f6ef6f1ff74ec530884148a
[05/10] regulator: dt-bindings: samsung,s2mpa01: convert to dtschema
        commit: a52afb0f54faae0366575d47cbd85165ce34deda
[06/10] regulator: dt-bindings: samsung,s5m8767: convert to dtschema
        commit: fab58debc137f66cf97f60c8471ff2f1e3e1b44b

Best regards,
Krzysztof Kozlowski Oct. 18, 2021, 2:02 p.m. UTC | #3
On 08/10/2021 20:54, Mark Brown wrote:
> On Fri, Oct 08, 2021 at 01:37:12PM +0200, Krzysztof Kozlowski wrote:
> 
>> This patchset converts all devicetree bindings of Samsung S2M and S5M
>> PMIC devices from txt to dtschema.
> 
> The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:
> 
>   Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/s2m_s5m_dtschema
> 
> for you to fetch changes up to fab58debc137f66cf97f60c8471ff2f1e3e1b44b:
> 
>   regulator: dt-bindings: samsung,s5m8767: convert to dtschema (2021-10-08 17:24:37 +0100)
> 

Thanks Mark for the branch.

Lee, can you merge it and apply the rest (MFD)?


Best regards,
Krzysztof
Lee Jones Oct. 18, 2021, 3:38 p.m. UTC | #4
On Mon, 18 Oct 2021, Krzysztof Kozlowski wrote:

> On 08/10/2021 20:54, Mark Brown wrote:
> > On Fri, Oct 08, 2021 at 01:37:12PM +0200, Krzysztof Kozlowski wrote:
> > 
> >> This patchset converts all devicetree bindings of Samsung S2M and S5M
> >> PMIC devices from txt to dtschema.
> > 
> > The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:
> > 
> >   Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/s2m_s5m_dtschema
> > 
> > for you to fetch changes up to fab58debc137f66cf97f60c8471ff2f1e3e1b44b:
> > 
> >   regulator: dt-bindings: samsung,s5m8767: convert to dtschema (2021-10-08 17:24:37 +0100)
> > 
> 
> Thanks Mark for the branch.
> 
> Lee, can you merge it and apply the rest (MFD)?

Sure.  I'll take a look in a bit.