| Message ID | 163429018454.1146856.3429437540871060739.stgit@bahia.huguette (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | softmmu/physmem.c: Fix typo in comment | expand |
Le 15/10/2021 à 11:29, Greg Kurz a écrit : > Fix the comment to match what the code is doing, as explained in > the changelog of commit 86cf9e154632cb28d749db0ea47946fba8cf3f09 > that introduced the change: > > Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization > of vCPU and migration operations through calling run_on_cpu operation. > However, in replay mode this synchronization is unneeded, because > I/O and vCPU threads are already synchronized. > This patch disables such synchronization for record/replay mode. > > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > softmmu/physmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index f67ad2998121..555c907f6743 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener) > * In record/replay mode this causes a deadlock, because > * run_on_cpu waits for rr mutex. Therefore no races are possible > * in this case and no need for making run_on_cpu when > - * record/replay is not enabled. > + * record/replay is enabled. > */ > cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener); > run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL); > > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/softmmu/physmem.c b/softmmu/physmem.c index f67ad2998121..555c907f6743 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener) * In record/replay mode this causes a deadlock, because * run_on_cpu waits for rr mutex. Therefore no races are possible * in this case and no need for making run_on_cpu when - * record/replay is not enabled. + * record/replay is enabled. */ cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener); run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL);
Fix the comment to match what the code is doing, as explained in the changelog of commit 86cf9e154632cb28d749db0ea47946fba8cf3f09 that introduced the change: Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization of vCPU and migration operations through calling run_on_cpu operation. However, in replay mode this synchronization is unneeded, because I/O and vCPU threads are already synchronized. This patch disables such synchronization for record/replay mode. Signed-off-by: Greg Kurz <groug@kaod.org> --- softmmu/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)