[v5,0/3] hw/arm/virt_acpi_build: Generate DBG2 table

Message

Eric Auger Oct. 19, 2021, 8 a.m. UTC

This series generates the ACPI DBG2 table along with machvirt.

The DBG2 specification can be found at
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table.

DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale
behind is Windows requires it on all systems).

The DBG2 is used to describe a debug port, used by the kernel debugger.

The series can be found at:
https://github.com/eauger/qemu.git
branch: dbg2_v5

History:

v4 -> v5:
- added Drew and Igor's R-b on patch 2.

v3 -> v4:
- fix revision in header (0)
- added Michael's R-b
- address 2 minor style issues (Drew, Igor)

v2 -> v3:
- addressed all comments from Igor on v2:
  patches 2/3 swapped
  style adjustments in "hw/arm/virt_acpi_build: Generate DBG2 table"
  + more precision on spec references

v1 -> v2:
- rebase on top of Igor's series and use acpi_init_table/acpi_table_composed
  and build_append_int_noprefix()


Eric Auger (3):
  tests/acpi: Add void table for virt/DBG2 bios-tables-test
  hw/arm/virt_acpi_build: Generate DBG2 table
  bios-tables-test: Generate reference table for virt/DBG2

 hw/arm/virt-acpi-build.c  |  63 +++++++++++++++++++++++++++++++++++++-
 tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes
 2 files changed, 62 insertions(+), 1 deletion(-)
 create mode 100644 tests/data/acpi/virt/DBG2

Comments

Richard Henderson Oct. 19, 2021, 4:09 p.m. UTC | #1

On 10/19/21 1:00 AM, Eric Auger wrote:
> This series generates the ACPI DBG2 table along with machvirt.
> 
> The DBG2 specification can be found at
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table.
> 
> DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale
> behind is Windows requires it on all systems).
> 
> The DBG2 is used to describe a debug port, used by the kernel debugger.
> 
> The series can be found at:
> https://github.com/eauger/qemu.git
> branch: dbg2_v5
> 
> History:
> 
> v4 -> v5:
> - added Drew and Igor's R-b on patch 2.
> 
> v3 -> v4:
> - fix revision in header (0)
> - added Michael's R-b
> - address 2 minor style issues (Drew, Igor)
> 
> v2 -> v3:
> - addressed all comments from Igor on v2:
>    patches 2/3 swapped
>    style adjustments in "hw/arm/virt_acpi_build: Generate DBG2 table"
>    + more precision on spec references
> 
> v1 -> v2:
> - rebase on top of Igor's series and use acpi_init_table/acpi_table_composed
>    and build_append_int_noprefix()
> 
> 
> Eric Auger (3):
>    tests/acpi: Add void table for virt/DBG2 bios-tables-test
>    hw/arm/virt_acpi_build: Generate DBG2 table
>    bios-tables-test: Generate reference table for virt/DBG2
> 
>   hw/arm/virt-acpi-build.c  |  63 +++++++++++++++++++++++++++++++++++++-
>   tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes
>   2 files changed, 62 insertions(+), 1 deletion(-)
>   create mode 100644 tests/data/acpi/virt/DBG2

Thanks, applied to target-arm.next.

r~