| Message ID | 20211020110624.47696-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v2] crypto: s5p-sss - Add error handling in s5p_aes_probe() | expand |
On 20/10/2021 13:06, Tang Bin wrote: > The function s5p_aes_probe() does not perform sufficient error > checking after executing platform_get_resource(), thus fix it. > > Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Changes from v1 > - add fixed title > --- > drivers/crypto/s5p-sss.c | 2 ++ > 1 file changed, 2 insertions(+) > You still missed the cc-stable tag. I pasted it last time. Cc: <stable@vger.kernel.org> Best regards, Krzysztof
On Wed, Oct 20, 2021 at 07:06:24PM +0800, Tang Bin wrote: > The function s5p_aes_probe() does not perform sufficient error > checking after executing platform_get_resource(), thus fix it. > > Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Changes from v1 > - add fixed title > --- > drivers/crypto/s5p-sss.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 55aa3a711..7717e9e59 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) > > variant = find_s5p_sss_version(pdev); > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; > > /* > * Note: HASH and PRNG uses the same registers in secss, avoid > -- > 2.20.1.windows.1 > > > <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>
Hi, Krzysztof： On 2021/10/20 19:38, Krzysztof Kozlowski wrote: > On 20/10/2021 13:06, Tang Bin wrote: >> The function s5p_aes_probe() does not perform sufficient error >> checking after executing platform_get_resource(), thus fix it. >> >> Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> Changes from v1 >> - add fixed title >> --- >> drivers/crypto/s5p-sss.c | 2 ++ >> 1 file changed, 2 insertions(+) >> > You still missed the cc-stable tag. I pasted it last time. > Cc: <stable@vger.kernel.org> I am deeply sorry for my patch v2，I thought it to cc when use git to send-email. I am sorry to waste your precious time. I will correct it immediately. Thanks Tang Bin > Best regards, > Krzysztof
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 55aa3a711..7717e9e59 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) variant = find_s5p_sss_version(pdev); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; /* * Note: HASH and PRNG uses the same registers in secss, avoid
The function s5p_aes_probe() does not perform sufficient error checking after executing platform_get_resource(), thus fix it. Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Changes from v1 - add fixed title --- drivers/crypto/s5p-sss.c | 2 ++ 1 file changed, 2 insertions(+)