| Message ID | 20160828165815.25647-1-nicolas.iooss_linux@m4x.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28/08/16 18:58, Nicolas Iooss wrote: > Adding such an attribute is helpful to detect errors related to printf > formats at compile-time. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > --- > arch/arm/include/asm/setup.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > index 3613d7e9fc40..797b8505b49a 100644 > --- a/arch/arm/include/asm/setup.h > +++ b/arch/arm/include/asm/setup.h > @@ -22,7 +22,7 @@ > static const struct tagtable __tagtable_##fn __tag = { tag, fn } > > extern int arm_add_memory(u64 start, u64 size); > -extern void early_print(const char *str, ...); > +extern __printf(1, 2) void early_print(const char *str, ...); > extern void dump_machine_table(void); > > #ifdef CONFIG_ATAGS_PROC Hello, I sent this patch a few weeks ago and got no reply (and nothing showed up on https://patchwork.kernel.org/patch/9302825/). Could you please consider it for 4.9? Thanks, Nicolas
On Sun, Aug 28, 2016 at 6:59 PM Nicolas Iooss <nicolas.iooss_linux@m4x.org> wrote: > Adding such an attribute is helpful to detect errors related to printf > formats at compile-time. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> and submitted to rmk's patch tracker. https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9147/1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index 3613d7e9fc40..797b8505b49a 100644 --- a/arch/arm/include/asm/setup.h +++ b/arch/arm/include/asm/setup.h @@ -22,7 +22,7 @@ static const struct tagtable __tagtable_##fn __tag = { tag, fn } extern int arm_add_memory(u64 start, u64 size); -extern void early_print(const char *str, ...); +extern __printf(1, 2) void early_print(const char *str, ...); extern void dump_machine_table(void); #ifdef CONFIG_ATAGS_PROC
Adding such an attribute is helpful to detect errors related to printf formats at compile-time. Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> --- arch/arm/include/asm/setup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)