| Message ID | 1634732051-31282-3-git-send-email-quic_sbillaka@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add support for eDP on SC7280 | expand |
Hi, On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti <quic_sbillaka@quicinc.com> wrote: > > From: Sankeerth Billakanti <sbillaka@codeaurora.org> > > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to dp-controller. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + > 1 file changed, 1 insertion(+) I think you ignored some of the feedback that was given on v1. Perhaps you could go back and re-read that feedback? See the replies to: https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbillaka@codeaurora.org/ For one, ${SUBJECT} needs updating. It's probably as simple as adding the "msm/dp" tag, like: dt-bindings: msm/dp: Add SC7280 compatible string For another, Stephen requested that you add "sc7280-dp" too.
Hi Doug, Sorry about that, this is the first time I am posting changes upstream and still getting hold of conventions. I think I misinterpreted your subject line comment and changed the just title to include dp-controller. I will correct it in the next version. sc7280-dp will be added later when dp support for sc7280 will be posted. I will reply on the feedback email from Stephen. Thank you, Sankeerth -----Original Message----- From: Doug Anderson <dianders@chromium.org> Sent: Wednesday, October 20, 2021 11:11 PM To: quic_sbillaka <quic_sbillaka@quicinc.com> Cc: dri-devel <dri-devel@lists.freedesktop.org>; linux-arm-msm <linux-arm-msm@vger.kernel.org>; freedreno <freedreno@lists.freedesktop.org>; LKML <linux-kernel@vger.kernel.org>; Sankeerth Billakanti <sbillaka@codeaurora.org>; Rob Clark <robdclark@gmail.com>; Sean Paul <seanpaul@chromium.org>; Stephen Boyd <swboyd@chromium.org>; Kalyan Thota <kalyan_t@codeaurora.org>; Abhinav Kumar <abhinavk@codeaurora.org>; Kuogee Hsieh <khsieh@codeaurora.org>; Krishna Manikandan <mkrishn@codeaurora.org> Subject: Re: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Hi, On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti <quic_sbillaka@quicinc.com> wrote: > > From: Sankeerth Billakanti <sbillaka@codeaurora.org> > > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to dp-controller. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 > + > 1 file changed, 1 insertion(+) I think you ignored some of the feedback that was given on v1. Perhaps you could go back and re-read that feedback? See the replies to: https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbillaka@codeaurora.org/ For one, ${SUBJECT} needs updating. It's probably as simple as adding the "msm/dp" tag, like: dt-bindings: msm/dp: Add SC7280 compatible string For another, Stephen requested that you add "sc7280-dp" too.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 63e585f..ab2bb1b 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -17,6 +17,7 @@ properties: compatible: enum: - qcom,sc7180-dp + - qcom,sc7280-edp - qcom,sc8180x-dp - qcom,sc8180x-edp