| Message ID | 1634028078-2387-7-git-send-email-hongxing.zhu@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add the imx8m pcie phy driver and imx8mm pcie support | expand |
On Tue, Oct 12, 2021 at 04:41:15PM +0800, Richard Zhu wrote: > i.MX8MM PCIe has the PHY. Add a PHY phandle and name properties > in the binding document. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 2911e565b260..99d9863a69cd 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -128,6 +128,12 @@ properties: > enum: [1, 2, 3, 4] > default: 1 > > + phys: > + description: Phandle of the Generic PHY to the PCIe PHY. maxItems: 1 And drop 'description' > + > + phy-names: > + const: pcie-phy > + > reset-gpio: > description: Should specify the GPIO for controlling the PCI bus device > reset signal. It's not polarity aware and defaults to active-low reset > -- > 2.25.1 > >
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Tuesday, October 19, 2021 3:18 AM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; tharvey@gateworks.com; kishon@ti.com; > vkoul@kernel.org; galak@kernel.crashing.org; shawnguo@kernel.org; > linux-phy@lists.infradead.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v3 6/9] dt-bindings: imx6q-pcie: Add PHY phandles and > name properties > > On Tue, Oct 12, 2021 at 04:41:15PM +0800, Richard Zhu wrote: > > i.MX8MM PCIe has the PHY. Add a PHY phandle and name properties in the > > binding document. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 2911e565b260..99d9863a69cd 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -128,6 +128,12 @@ properties: > > enum: [1, 2, 3, 4] > > default: 1 > > > > + phys: > > + description: Phandle of the Generic PHY to the PCIe PHY. > > maxItems: 1 > > And drop 'description' [Richard Zhu] Hi Rob: Do you mean to remove all the description, and just like this? phys: maxItems: 1 Ok, got that, would be changed as this one in v4 series later. Thanks. Best Regards Richard Zhu > > > + > > + phy-names: > > + const: pcie-phy > > + > > reset-gpio: > > description: Should specify the GPIO for controlling the PCI bus > device > > reset signal. It's not polarity aware and defaults to > > active-low reset > > -- > > 2.25.1 > > > >
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 2911e565b260..99d9863a69cd 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -128,6 +128,12 @@ properties: enum: [1, 2, 3, 4] default: 1 + phys: + description: Phandle of the Generic PHY to the PCIe PHY. + + phy-names: + const: pcie-phy + reset-gpio: description: Should specify the GPIO for controlling the PCI bus device reset signal. It's not polarity aware and defaults to active-low reset
i.MX8MM PCIe has the PHY. Add a PHY phandle and name properties in the binding document. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++ 1 file changed, 6 insertions(+)