mbox series

[0/6] ath11k: support one MSI vector

Message ID 20201223030225.2345-1-cjhuang@codeaurora.org (mailing list archive)
Headers show
Series ath11k: support one MSI vector | expand

Message

Carl Huang Dec. 23, 2020, 3:02 a.m. UTC
This patch set is to support one MSI vector for QCA6390.

Carl Huang (6):
  ath11k: get msi_data again after request_irq is called
  ath11k: add ce and ext irq flag to indicate irq_handler
  ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for dp irqx
  ath11k: refactor mulitple msi vector implementation
  ath11k: supports one MSI vector
  ath11k: do not restore ASPM in case of single MSI vector

 drivers/net/wireless/ath/ath11k/core.h |   2 +
 drivers/net/wireless/ath/ath11k/mhi.c  |  13 ++-
 drivers/net/wireless/ath/ath11k/pci.c  | 200 +++++++++++++++++++++++++++------
 drivers/net/wireless/ath/ath11k/pci.h  |   8 ++
 4 files changed, 189 insertions(+), 34 deletions(-)

Comments

Kalle Valo Feb. 11, 2021, 7:07 a.m. UTC | #1
Carl Huang <cjhuang@codeaurora.org> writes:

> This patch set is to support one MSI vector for QCA6390.
>
> Carl Huang (6):
>   ath11k: get msi_data again after request_irq is called
>   ath11k: add ce and ext irq flag to indicate irq_handler
>   ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for dp irqx
>   ath11k: refactor mulitple msi vector implementation
>   ath11k: supports one MSI vector
>   ath11k: do not restore ASPM in case of single MSI vector

I did some cleanup and before submitting v2 I noticed the patchset (both
v1 and v2) is crashing during suspend on my Dell XPS 13 9310. We are
investigating the reason for that and will submit v2 once those are
fixed.
Janusz Dziedzic Oct. 22, 2021, 8:04 a.m. UTC | #2
czw., 11 lut 2021 o 08:10 Kalle Valo <kvalo@codeaurora.org> napisał(a):
>
> Carl Huang <cjhuang@codeaurora.org> writes:
>
> > This patch set is to support one MSI vector for QCA6390.
> >
> > Carl Huang (6):
> >   ath11k: get msi_data again after request_irq is called
> >   ath11k: add ce and ext irq flag to indicate irq_handler
> >   ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for dp irqx
> >   ath11k: refactor mulitple msi vector implementation
> >   ath11k: supports one MSI vector
> >   ath11k: do not restore ASPM in case of single MSI vector
>
> I did some cleanup and before submitting v2 I noticed the patchset (both
> v1 and v2) is crashing during suspend on my Dell XPS 13 9310. We are
> investigating the reason for that and will submit v2 once those are
> fixed.
>
Hello Kalle,

What is status for this series?
I am using ath11k in my banana-pi-r64 (backports-5.15-rc6) board and hit:
[  162.392043] ath11k_pci 0000:01:00.0: failed to get 32 MSI vectors,
only -28 available
[  162.399927] ath11k_pci 0000:01:00.0: failed to enable msi: -28
[  162.405778] ath11k_pci 0000:01:00.0: disabling bus mastering
[  162.411481] ath11k_pci: probe of 0000:01:00.0 failed with error -28

I suspect this series should fix my issue?

BR
Janusz

> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo Nov. 15, 2021, 10:43 a.m. UTC | #3
Janusz Dziedzic <janusz.dziedzic@gmail.com> writes:

> czw., 11 lut 2021 o 08:10 Kalle Valo <kvalo@codeaurora.org> napisał(a):
>>
>> Carl Huang <cjhuang@codeaurora.org> writes:
>>
>> > This patch set is to support one MSI vector for QCA6390.
>> >
>> > Carl Huang (6):
>> >   ath11k: get msi_data again after request_irq is called
>> >   ath11k: add ce and ext irq flag to indicate irq_handler
>> >   ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for dp irqx
>> >   ath11k: refactor mulitple msi vector implementation
>> >   ath11k: supports one MSI vector
>> >   ath11k: do not restore ASPM in case of single MSI vector
>>
>> I did some cleanup and before submitting v2 I noticed the patchset (both
>> v1 and v2) is crashing during suspend on my Dell XPS 13 9310. We are
>> investigating the reason for that and will submit v2 once those are
>> fixed.
>>
> Hello Kalle,
>
> What is status for this series?

There's now a new version available:

https://patchwork.kernel.org/project/linux-wireless/cover/20211026041616.4956-1-bqiang@codeaurora.org/

If you can, please do test the version in the master-pending branch
(commit 9a914cfdbfd69):

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=master-pending

> I am using ath11k in my banana-pi-r64 (backports-5.15-rc6) board and hit:
> [  162.392043] ath11k_pci 0000:01:00.0: failed to get 32 MSI vectors,
> only -28 available
> [  162.399927] ath11k_pci 0000:01:00.0: failed to enable msi: -28
> [  162.405778] ath11k_pci 0000:01:00.0: disabling bus mastering
> [  162.411481] ath11k_pci: probe of 0000:01:00.0 failed with error -28
>
> I suspect this series should fix my issue?

Most likely this should fix it. You could also try changing your BIOS
settings to get more MSI vectors, IIRC enabling VT-d help on NUC boards
at least.