| Message ID | 20211021170414.3341522-1-maz@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | genirq: Make irq_cpu_{on,off}line() an Octeon-special | expand |
Hello Marc On Thu, Oct 21, 2021 at 06:04:11PM +0100, Marc Zyngier wrote: > Now that Florian has updated BMIPS to not rely on irq_cpu_offline [1], > it is pretty tempting to totally get of this misfeature. We can't > really do that because Octeon uses it like crazy, but the couple of > other users are easy to convert. > > Once this is done, these helpers are hidden behind a config symbol > that depends on the Octeon platform being selected. When Octeon is > finally removed from the tree, we'll be able to drop this as well. The whole series has been tested in kernel 5.13 running on Baikal-T1 SoC (2x P5600 cores) with MIPS GIC used as the clock source and clock event device. Acked-by: Serge Semin <fancer.lancer@gmail.com> -Sergey > > > Marc Zyngier (3): > MIPS: loongson64: Drop call to irq_cpu_offline() > irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() > genirq: Hide irq_cpu_{on,off}line() behind a deprecated option > > arch/mips/loongson64/smp.c | 1 - > drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- > include/linux/irq.h | 5 ++++- > kernel/irq/Kconfig | 7 +++++++ > kernel/irq/chip.c | 2 ++ > 5 files changed, 39 insertions(+), 13 deletions(-) > > -- > 2.30.2 >
On Fri, Oct 22, 2021 at 04:53:56PM +0300, Serge Semin wrote: > Hello Marc > > On Thu, Oct 21, 2021 at 06:04:11PM +0100, Marc Zyngier wrote: > > Now that Florian has updated BMIPS to not rely on irq_cpu_offline [1], > > it is pretty tempting to totally get of this misfeature. We can't > > really do that because Octeon uses it like crazy, but the couple of > > other users are easy to convert. > > > > Once this is done, these helpers are hidden behind a config symbol > > that depends on the Octeon platform being selected. When Octeon is > > finally removed from the tree, we'll be able to drop this as well. > > The whole series has been tested in kernel 5.13 running on > Baikal-T1 SoC (2x P5600 cores) with MIPS GIC used as the clock source > and clock event device. > Acked-by: Serge Semin <fancer.lancer@gmail.com> Ah, sorry. copy-pasted a wrong tag. Tested-by of course: Tested-by: Serge Semin <fancer.lancer@gmail.com> -Sergey > > -Sergey > > > > > > > Marc Zyngier (3): > > MIPS: loongson64: Drop call to irq_cpu_offline() > > irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() > > genirq: Hide irq_cpu_{on,off}line() behind a deprecated option > > > > arch/mips/loongson64/smp.c | 1 - > > drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- > > include/linux/irq.h | 5 ++++- > > kernel/irq/Kconfig | 7 +++++++ > > kernel/irq/chip.c | 2 ++ > > 5 files changed, 39 insertions(+), 13 deletions(-) > > > > -- > > 2.30.2 > >
Now that Florian has updated BMIPS to not rely on irq_cpu_offline [1], it is pretty tempting to totally get of this misfeature. We can't really do that because Octeon uses it like crazy, but the couple of other users are easy to convert. Once this is done, these helpers are hidden behind a config symbol that depends on the Octeon platform being selected. When Octeon is finally removed from the tree, we'll be able to drop this as well. Marc Zyngier (3): MIPS: loongson64: Drop call to irq_cpu_offline() irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() genirq: Hide irq_cpu_{on,off}line() behind a deprecated option arch/mips/loongson64/smp.c | 1 - drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 5 files changed, 39 insertions(+), 13 deletions(-)