| Message ID | 20211021194547.672988-2-matheus.ferst@eldorado.org.br (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PowerISA v3.1 instruction batch | expand |
On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote: > +static inline void do_ea_calc(DisasContext *ctx, int ra, TCGv displ, TCGv ea) > +{ > + if (ra) { > + tcg_gen_add_tl(ea, cpu_gpr[ra], displ); > + } else { > + tcg_gen_mov_tl(ea, displ); > + } > + if (NARROW_MODE(ctx)) { > + tcg_gen_ext32u_tl(ea, ea); > + } > +} Drop the inline. Allocate ea locally and return it? All uses do the allocate immediately beforehand... Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote: > From: pherde<phervalle@gmail.com> > > The do_ea_calc function will calculate the effective address(EA) > according to PowerIsa 3.1. With that, it was replaced part of > do_ldst() that calculates the EA by this new function. > > Signed-off-by: Fernando Eckhardt Valle (pherde)<phervalle@gmail.com> > Signed-off-by: Matheus Ferst<matheus.ferst@eldorado.org.br> > --- Oh, and please fix the commit author to Fernando's complete name. r~
diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 62414adb75..bb8edd9d8f 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -3197,6 +3197,18 @@ static inline void gen_align_no_le(DisasContext *ctx) (ctx->opcode & 0x03FF0000) | POWERPC_EXCP_ALIGN_LE); } +static inline void do_ea_calc(DisasContext *ctx, int ra, TCGv displ, TCGv ea) +{ + if (ra) { + tcg_gen_add_tl(ea, cpu_gpr[ra], displ); + } else { + tcg_gen_mov_tl(ea, displ); + } + if (NARROW_MODE(ctx)) { + tcg_gen_ext32u_tl(ea, ea); + } +} + /*** Integer load ***/ #define DEF_MEMOP(op) ((op) | ctx->default_tcg_memop_mask) #define BSWAP_MEMOP(op) ((op) | (ctx->default_tcg_memop_mask ^ MO_BSWAP)) diff --git a/target/ppc/translate/fixedpoint-impl.c.inc b/target/ppc/translate/fixedpoint-impl.c.inc index 2e2518ee15..53d8fbdcfe 100644 --- a/target/ppc/translate/fixedpoint-impl.c.inc +++ b/target/ppc/translate/fixedpoint-impl.c.inc @@ -52,14 +52,7 @@ static bool do_ldst(DisasContext *ctx, int rt, int ra, TCGv displ, bool update, gen_set_access_type(ctx, ACCESS_INT); ea = tcg_temp_new(); - if (ra) { - tcg_gen_add_tl(ea, cpu_gpr[ra], displ); - } else { - tcg_gen_mov_tl(ea, displ); - } - if (NARROW_MODE(ctx)) { - tcg_gen_ext32u_tl(ea, ea); - } + do_ea_calc(ctx, ra, displ, ea); mop ^= ctx->default_tcg_memop_mask; if (store) { tcg_gen_qemu_st_tl(cpu_gpr[rt], ea, ctx->mem_idx, mop);