| Message ID | 20210824105858.19496-1-rogerq@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: keystone-k2*-evm: Fix mdio and dss node status | expand |
On 24/08/2021 13:58, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" > > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Changes in this version: - updated commit message to point to DT spec instead of schema.
On 13:58-20210824, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. ^^ I suspect the above comment in the patches is to indicate side effect of non-compliance. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" Reviewed-by: Nishanth Menon <nm@ti.com>
Hi Santosh On 24/08/2021 13:58, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 Could you please queue these trivial fixes for 5.15? Thanks > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" > > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > cheers, -roger
Hi Santosh On 25/08/2021 19:17, Nishanth Menon wrote: > On 13:58-20210824, Roger Quadros wrote: >> Hi Santosh, >> >> This series fixes mdio and dss status nodes from "ok" to "okay" >> >> As per Device Tree Specification [1], the status parameter of nodes can >> be "okay", "disabled", etc. "ok" is not a valid parameter. >> >> U-boot Driver Model does not recognize status="ok" either and treats >> the node as disabled. > > ^^ I suspect the above comment in the patches is to indicate side effect > of non-compliance. > >> >> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 >> >> cheers, >> -roger >> >> Roger Quadros (2): >> ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" >> ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" > > > Reviewed-by: Nishanth Menon <nm@ti.com> > Is there a chance to still pull these in for -next? Thanks. cheers, -roger