| Message ID | 20211025213926.21203-2-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: BCM5301X: remove unnecessary address & size cells from Asus RT-AC88U | expand |
On 25.10.2021 23:39, Arınç ÜNAL wrote: > Define the Realtek RTL8365MB switch without interrupt support on the device tree of Asus RT-AC88U. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> ./scripts/checkpatch.pl doesn't like formatting in your patch: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: Define the Realtek RTL8365MB switch without interrupt support on the device tree of Asus RT-AC88U. This change introduces new "make ARCH=arm dtbs_check" validation warnings / errors: arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch: failed to match any schema with compatible: ['realtek,rtl8365mb'] arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch/mdio: failed to match any schema with compatible: ['realtek,smi-mdio'] /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: phy@0: '#phy-cells' is a required property From schema: /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: phy@1: '#phy-cells' is a required property From schema: /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: phy@2: '#phy-cells' is a required property From schema: /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: phy@3: '#phy-cells' is a required property From schema: /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml the first two are caused by realtek-smi.txt not being converted to YAML. Ignore them. Later are caused by using phy@ instead of ethernet-phy@ and have to be fixed.
On 26/10/2021 11:29, Rafał Miłecki wrote: > On 25.10.2021 23:39, Arınç ÜNAL wrote: >> Define the Realtek RTL8365MB switch without interrupt support on the >> device tree of Asus RT-AC88U. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > ./scripts/checkpatch.pl doesn't like formatting in your patch: > > WARNING: Possible unwrapped commit description (prefer a maximum 75 > chars per line) > #9: > Define the Realtek RTL8365MB switch without interrupt support on the > device tree of Asus RT-AC88U. > > > This change introduces new "make ARCH=arm dtbs_check" validation > warnings / errors: > > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch: failed to > match any schema with compatible: ['realtek,rtl8365mb'] > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch/mdio: > failed to match any schema with compatible: ['realtek,smi-mdio'] > /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: > phy@0: '#phy-cells' is a required property > From schema: > /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: > phy@1: '#phy-cells' is a required property > From schema: > /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: > phy@2: '#phy-cells' is a required property > From schema: > /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > /home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: > phy@3: '#phy-cells' is a required property > From schema: > /home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > > the first two are caused by realtek-smi.txt not being converted to YAML. > Ignore them. > > Later are caused by using phy@ instead of ethernet-phy@ and have to be > fixed. I'm going to address these in v2, thanks.
diff --git a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts index b0cee1d87600..6562ee435f88 100644 --- a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts +++ b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts @@ -93,6 +93,83 @@ led { gpios = <&chipcommon 4 GPIO_ACTIVE_LOW>; }; }; + + switch { + compatible = "realtek,rtl8365mb"; + /* 7 = MDIO (has input reads), 6 = MDC (clock, output only) */ + mdc-gpios = <&chipcommon 6 GPIO_ACTIVE_HIGH>; + mdio-gpios = <&chipcommon 7 GPIO_ACTIVE_HIGH>; + reset-gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; + realtek,disable-leds; + dsa,member = <1 0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + port@0 { + reg = <0>; + label = "lan5"; + phy-handle = <ðphy0>; + }; + + port@1 { + reg = <1>; + label = "lan6"; + phy-handle = <ðphy1>; + }; + + port@2 { + reg = <2>; + label = "lan7"; + phy-handle = <ðphy2>; + }; + + port@3 { + reg = <3>; + label = "lan8"; + phy-handle = <ðphy3>; + }; + + port@6 { + reg = <6>; + label = "cpu"; + ethernet = <&sw0_p5>; + phy-mode = "rgmii"; + tx-internal-delay-ps = <2000>; + rx-internal-delay-ps = <2000>; + + fixed-link { + speed = <1000>; + full-duplex; + pause; + }; + }; + }; + + mdio { + compatible = "realtek,smi-mdio"; + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: phy@0 { + reg = <0>; + }; + + ethphy1: phy@1 { + reg = <1>; + }; + + ethphy2: phy@2 { + reg = <2>; + }; + + ethphy3: phy@3 { + reg = <3>; + }; + }; + }; }; &srab {
Define the Realtek RTL8365MB switch without interrupt support on the device tree of Asus RT-AC88U. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 77 ++++++++++++++++++++ 1 file changed, 77 insertions(+)