| Message ID | 20211026191703.1174086-1-clabbe@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ethernet: cortina: permit to set mac address in DT | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Tue, Oct 26, 2021 at 9:17 PM Corentin Labbe <clabbe@baylibre.com> wrote: > Add ability of setting mac address in DT for cortina ethernet driver. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> That looks useful! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote: > Add ability of setting mac address in DT for cortina ethernet driver. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > drivers/net/ethernet/cortina/gemini.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c > index 941f175fb911..f6aa2387a1af 100644 > --- a/drivers/net/ethernet/cortina/gemini.c > +++ b/drivers/net/ethernet/cortina/gemini.c > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port) > static int gemini_ethernet_port_probe(struct platform_device *pdev) > { > char *port_names[2] = { "ethernet0", "ethernet1" }; > + struct device_node *np = pdev->dev.of_node; > struct gemini_ethernet_port *port; > struct device *dev = &pdev->dev; > struct gemini_ethernet *geth; > struct net_device *netdev; > struct device *parent; > unsigned int id; > + u8 mac[ETH_ALEN]; Off by one in terms of reverse Christmas tree. Andrew
Le Wed, Oct 27, 2021 at 02:08:04AM +0200, Andrew Lunn a écrit : > On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote: > > Add ability of setting mac address in DT for cortina ethernet driver. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > drivers/net/ethernet/cortina/gemini.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c > > index 941f175fb911..f6aa2387a1af 100644 > > --- a/drivers/net/ethernet/cortina/gemini.c > > +++ b/drivers/net/ethernet/cortina/gemini.c > > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port) > > static int gemini_ethernet_port_probe(struct platform_device *pdev) > > { > > char *port_names[2] = { "ethernet0", "ethernet1" }; > > + struct device_node *np = pdev->dev.of_node; > > struct gemini_ethernet_port *port; > > struct device *dev = &pdev->dev; > > struct gemini_ethernet *geth; > > struct net_device *netdev; > > struct device *parent; > > unsigned int id; > > + u8 mac[ETH_ALEN]; > > Off by one in terms of reverse Christmas tree. > Hello I will fix it in a v2 Thanks Regards
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 941f175fb911..f6aa2387a1af 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port) static int gemini_ethernet_port_probe(struct platform_device *pdev) { char *port_names[2] = { "ethernet0", "ethernet1" }; + struct device_node *np = pdev->dev.of_node; struct gemini_ethernet_port *port; struct device *dev = &pdev->dev; struct gemini_ethernet *geth; struct net_device *netdev; struct device *parent; unsigned int id; + u8 mac[ETH_ALEN]; int irq; int ret; @@ -2466,6 +2468,12 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev) netif_napi_add(netdev, &port->napi, gmac_napi_poll, DEFAULT_NAPI_WEIGHT); + ret = of_get_mac_address(np, mac); + if (!ret) { + dev_info(dev, "Setting macaddr from DT %pM\n", mac); + memcpy(port->mac_addr, mac, ETH_ALEN); + } + if (is_valid_ether_addr((void *)port->mac_addr)) { eth_hw_addr_set(netdev, (u8 *)port->mac_addr); } else {
Add ability of setting mac address in DT for cortina ethernet driver. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- drivers/net/ethernet/cortina/gemini.c | 8 ++++++++ 1 file changed, 8 insertions(+)