| Message ID | 20211027215531.9996-1-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/3] dt-bindings: watchdog: add Broadcom's BCM63xx watchdog | expand |
On 10/27/21 2:55 PM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > It's a block that can be found on old MIPS devices as well as on > relatively new BCM4908. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/watchdog/brcm,bcm63xx-wdt.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml > new file mode 100644 > index 000000000000..f89bdefdeb19 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/brcm,bcm63xx-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BCM63xx watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Rafał Miłecki <rafal@milecki.pl> > + > +properties: > + compatible: > + enum: > + - brcm,bcm3368-wdt > + - brcm,bcm4908-wdt > + - brcm,bcm6328-wdt > + - brcm,bcm6338-wdt > + - brcm,bcm6345-wdt > + - brcm,bcm6348-wdt > + - brcm,bcm6358-wdt > + - brcm,bcm6362-wdt > + - brcm,bcm6368-wdt > + - brcm,bcm6838-wdt > + - brcm,bcm6848-wdt > + - brcm,bcm6858-wdt > + - brcm,bcm60333-wdt > + - brcm,bcm63138-wdt > + - brcm,bcm63148-wdt > + - brcm,bcm63268-wdt > + - brcm,bcm63381-wdt > + - brcm,bcm68360-wdt That's a lot of compatible strings for a piece of hardware that has not really change from the venerable BCM6345 days. I believe if you use only "brcm,bcm6345-wdt" we ought to have everything covered. Similar to the bcm63xx-uart binding.
śr., 27 paź 2021 o 23:55 Rafał Miłecki <zajec5@gmail.com> napisał(a): > From: Rafał Miłecki <rafal@milecki.pl> > > It's a block that can be found on old MIPS devices as well as on > relatively new BCM4908. After receiving some feedback: please drop this patchset.
diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml new file mode 100644 index 000000000000..f89bdefdeb19 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/brcm,bcm63xx-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BCM63xx watchdog + +allOf: + - $ref: "watchdog.yaml#" + +maintainers: + - Rafał Miłecki <rafal@milecki.pl> + +properties: + compatible: + enum: + - brcm,bcm3368-wdt + - brcm,bcm4908-wdt + - brcm,bcm6328-wdt + - brcm,bcm6338-wdt + - brcm,bcm6345-wdt + - brcm,bcm6348-wdt + - brcm,bcm6358-wdt + - brcm,bcm6362-wdt + - brcm,bcm6368-wdt + - brcm,bcm6838-wdt + - brcm,bcm6848-wdt + - brcm,bcm6858-wdt + - brcm,bcm60333-wdt + - brcm,bcm63138-wdt + - brcm,bcm63148-wdt + - brcm,bcm63268-wdt + - brcm,bcm63381-wdt + - brcm,bcm68360-wdt + + reg: + maxItems: 1 + +unevaluatedProperties: false + +required: + - reg + +examples: + - | + watchdog@ff800400 { + compatible = "brcm,bcm4908-wdt"; + reg = <0xff800400 0x3c>; + };