diff mbox series

ima/evm: mark evm_fixmode as __ro_after_init

Message ID 20211026224354.GA13009@raspberrypi (mailing list archive)
State New, archived
Headers show
Series ima/evm: mark evm_fixmode as __ro_after_init | expand

Commit Message

Austin Kim Oct. 26, 2021, 10:43 p.m. UTC 
From: Austin Kim <austin.kim@lge.com>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.

Signed-off-by: Austin Kim <austin.kim@lge.com>
---
 security/integrity/evm/evm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mimi Zohar Oct. 28, 2021, 12:27 a.m. UTC | #1 
Hi Austin,

The subject line should be just "evm:".

On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
> 
> evm_fixmode global variable is never modified
> outside initcalls, so declaring it with __ro_after_init is better.

Please properly format the text.  From
Documentation/process/submitting-patches.rst:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

> 
> Signed-off-by: Austin Kim <austin.kim@lge.com>

Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Austin Kim Oct. 28, 2021, 1:48 a.m. UTC | #2 
Hello Mimi,

2021년 10월 28일 (목) 오전 9:27, Mimi Zohar <zohar@linux.ibm.com>님이 작성:
>
> Hi Austin,
>
> The subject line should be just "evm:".
>
> On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > evm_fixmode global variable is never modified
> > outside initcalls, so declaring it with __ro_after_init is better.
>
> Please properly format the text.  From
> Documentation/process/submitting-patches.rst:
>
>   - The body of the explanation, line wrapped at 75 columns, which will
>     be copied to the permanent changelog to describe this patch.

Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-format.

BR,
Austin Kim

>
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
>
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
diff mbox series

Patch

diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
index 1c8435dfabee..08f907382c61 100644
--- a/security/integrity/evm/evm_main.c
+++ b/security/integrity/evm/evm_main.c
@@ -78,7 +78,7 @@  static struct xattr_list evm_config_default_xattrnames[] = {
 
 LIST_HEAD(evm_config_xattrnames);
 
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
 static int __init evm_set_fixmode(char *str)
 {
 	if (strncmp(str, "fix", 3) == 0)