[0/2] clk: rockchip: cleanup errors in (module-)driver handling

Message

Heiko Stübner Oct. 27, 2021, 1:26 p.m. UTC

Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
and subsequently allowing them to be built as modules introduced some
problems.

These two patches try to correct them.

Heiko Stuebner (2):
  Revert "clk: rockchip: use module_platform_driver_probe"
  clk: rockchip: drop module parts from rk3399 and rk3568 drivers

 drivers/clk/rockchip/Kconfig      | 4 ++--
 drivers/clk/rockchip/clk-rk3399.c | 6 +-----
 drivers/clk/rockchip/clk-rk3568.c | 6 +-----
 3 files changed, 4 insertions(+), 12 deletions(-)

Comments

Stephen Boyd Oct. 27, 2021, 8:27 p.m. UTC | #1

Quoting Heiko Stuebner (2021-10-27 06:26:14)
> Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> and subsequently allowing them to be built as modules introduced some
> problems.
> 
> These two patches try to correct them.

By removing modular support? Ok.

Heiko Stübner Oct. 27, 2021, 11:20 p.m. UTC | #2

Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > and subsequently allowing them to be built as modules introduced some
> > problems.
> > 
> > These two patches try to correct them.
> 
> By removing modular support? Ok.

It looked like the easiest way to go for now.

With all the clock-definitions as init-data still in both drivers, I don't think
anybody ever tested running this as a real module.

We could of course also remove all the __init + __initdata attributes, but
still wouldn't know if it actually runs as a module, without someone
building a real test environment for it.


Heiko

Stephen Boyd Oct. 29, 2021, 6:43 a.m. UTC | #3

Quoting Heiko Stübner (2021-10-27 16:20:17)
> Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> > Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > > and subsequently allowing them to be built as modules introduced some
> > > problems.
> > > 
> > > These two patches try to correct them.
> > 
> > By removing modular support? Ok.
> 
> It looked like the easiest way to go for now.
> 
> With all the clock-definitions as init-data still in both drivers, I don't think
> anybody ever tested running this as a real module.
> 
> We could of course also remove all the __init + __initdata attributes, but
> still wouldn't know if it actually runs as a module, without someone
> building a real test environment for it.
> 
> 

Sure. Do I need to pick these up directly?

Heiko Stübner Oct. 29, 2021, 12:37 p.m. UTC | #4

Am Freitag, 29. Oktober 2021, 08:43:05 CEST schrieb Stephen Boyd:
> Quoting Heiko Stübner (2021-10-27 16:20:17)
> > Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> > > Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > > > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > > > and subsequently allowing them to be built as modules introduced some
> > > > problems.
> > > > 
> > > > These two patches try to correct them.
> > > 
> > > By removing modular support? Ok.
> > 
> > It looked like the easiest way to go for now.
> > 
> > With all the clock-definitions as init-data still in both drivers, I don't think
> > anybody ever tested running this as a real module.
> > 
> > We could of course also remove all the __init + __initdata attributes, but
> > still wouldn't know if it actually runs as a module, without someone
> > building a real test environment for it.
> > 
> > 
> 
> Sure. Do I need to pick these up directly?

I don't have anything more for 5.16 and the 5.15 release should happen
on sunday, so yeah just pick them if you like - no need for doing a separate
pull request.

Thanks
Heiko

Stephen Boyd Nov. 3, 2021, 12:59 a.m. UTC | #5

Quoting Heiko Stübner (2021-10-29 05:37:06)
> Am Freitag, 29. Oktober 2021, 08:43:05 CEST schrieb Stephen Boyd:
> > Quoting Heiko St�bner (2021-10-27 16:20:17)
> > > Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> > > > Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > > > > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > > > > and subsequently allowing them to be built as modules introduced some
> > > > > problems.
> > > > > 
> > > > > These two patches try to correct them.
> > > > 
> > > > By removing modular support? Ok.
> > > 
> > > It looked like the easiest way to go for now.
> > > 
> > > With all the clock-definitions as init-data still in both drivers, I don't think
> > > anybody ever tested running this as a real module.
> > > 
> > > We could of course also remove all the __init + __initdata attributes, but
> > > still wouldn't know if it actually runs as a module, without someone
> > > building a real test environment for it.
> > > 
> > > 
> > 
> > Sure. Do I need to pick these up directly?
> 
> I don't have anything more for 5.16 and the 5.15 release should happen
> on sunday, so yeah just pick them if you like - no need for doing a separate
> pull request.
> 

Ok I picked them up and I'll send them off next week.