diff mbox series

[v2,5/7] watchdog: bcm7038_wdt: Add platform device id for bcm63xx-wdt

Message ID 20211029183430.4086765-6-f.fainelli@gmail.com (mailing list archive)
State Superseded
Headers show
Series Removal of bcm63xx-wdt | expand

Commit Message

Florian Fainelli Oct. 29, 2021, 6:34 p.m. UTC 
In order to phase out bcm63xx_wdt and use bcm7038_wdt instead, introduce
a platform_device_id table that allows both names to be matched.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/watchdog/bcm7038_wdt.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

kernel test robot Oct. 30, 2021, 6:58 a.m. UTC | #1 
Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linux/master groeck-staging/hwmon-next linus/master v5.15-rc7 next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Florian-Fainelli/Removal-of-bcm63xx-wdt/20211030-023646
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-randconfig-r002-20211028 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/3848f68f0fd262b6cf79422b1efc8e3cd9005716
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Florian-Fainelli/Removal-of-bcm63xx-wdt/20211030-023646
        git checkout 3848f68f0fd262b6cf79422b1efc8e3cd9005716
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/watchdog/bcm7038_wdt.c:226:40: warning: unused variable 'bcm7038_wdt_devtype' [-Wunused-const-variable]
   static const struct platform_device_id bcm7038_wdt_devtype[] = {
                                          ^
   1 warning generated.


vim +/bcm7038_wdt_devtype +226 drivers/watchdog/bcm7038_wdt.c

   225	
 > 226	static const struct platform_device_id bcm7038_wdt_devtype[] = {
   227		{ .name = "bcm7038-wdt" },
   228		{ .name = "bcm63xx-wdt" },
   229		{ /* sentinel */ },
   230	};
   231	MODULE_DEVICE_TABLE(platform, bcm7038_wdt_devtype);
   232	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/drivers/watchdog/bcm7038_wdt.c b/drivers/watchdog/bcm7038_wdt.c
index 506cd7ef9c77..2535f450e8a1 100644
--- a/drivers/watchdog/bcm7038_wdt.c
+++ b/drivers/watchdog/bcm7038_wdt.c
@@ -223,6 +223,13 @@  static const struct of_device_id bcm7038_wdt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, bcm7038_wdt_match);
 
+static const struct platform_device_id bcm7038_wdt_devtype[] = {
+	{ .name = "bcm7038-wdt" },
+	{ .name = "bcm63xx-wdt" },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(platform, bcm7038_wdt_devtype);
+
 static struct platform_driver bcm7038_wdt_driver = {
 	.probe		= bcm7038_wdt_probe,
 	.driver		= {