diff mbox series

cxl/cxlmem: Remove unused cxlmd field

Message ID 20211103204103.3687550-1-ira.weiny@intel.com
State Accepted
Commit a91bd78967c49b43d2835695c7b53b11170c98f4
Headers show
Series cxl/cxlmem: Remove unused cxlmd field | expand

Commit Message

Ira Weiny Nov. 3, 2021, 8:41 p.m. UTC 
From: Ira Weiny <ira.weiny@intel.com>

This field was left over when the connection between the cxl_memdev and
cxl_mem was tighter.  It is no longer set nor used so remove it.[1]

[1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/

Suggested-by: Jonathan.Cameron@huawei.com
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 drivers/cxl/cxlmem.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Dan Williams Nov. 3, 2021, 10:13 p.m. UTC | #1 
On Wed, Nov 3, 2021 at 1:41 PM <ira.weiny@intel.com> wrote:
>
> From: Ira Weiny <ira.weiny@intel.com>
>
> This field was left over when the connection between the cxl_memdev and
> cxl_mem was tighter.  It is no longer set nor used so remove it.[1]
>
> [1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/

Looks good, although I'll probably fixup the subject to:

    cxl/memdev: Remove unused cxlmd field

...to start to standardize on a prefix format of
cxl/$(infrastructure_area/C file name). Previous commits used
"cxl/mem:", but I think going forward that prefix can be used for
changes related to the driver in "cxl_mem.ko". Where "cxl/memdev:" is
for changes related to the base 'struct cxl_memdev' infrastructure.

The only reason that drivers/cxl/cxlmem.h has that redundant mention
of "cxl" in filename is to avoid collisions with
"arch/um/include/shared/mem.h" on ARCH=um builds. So "cxl/cxlmem:"
triggered my naming finickiness.
Ben Widawsky Nov. 3, 2021, 10:34 p.m. UTC | #2 
On 21-11-03 15:13:21, Dan Williams wrote:
> On Wed, Nov 3, 2021 at 1:41 PM <ira.weiny@intel.com> wrote:
> >
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > This field was left over when the connection between the cxl_memdev and
> > cxl_mem was tighter.  It is no longer set nor used so remove it.[1]
> >
> > [1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/
> 
> Looks good, although I'll probably fixup the subject to:
> 
>     cxl/memdev: Remove unused cxlmd field
> 
> ...to start to standardize on a prefix format of
> cxl/$(infrastructure_area/C file name). Previous commits used
> "cxl/mem:", but I think going forward that prefix can be used for
> changes related to the driver in "cxl_mem.ko". Where "cxl/memdev:" is
> for changes related to the base 'struct cxl_memdev' infrastructure.
> 
> The only reason that drivers/cxl/cxlmem.h has that redundant mention
> of "cxl" in filename is to avoid collisions with
> "arch/um/include/shared/mem.h" on ARCH=um builds. So "cxl/cxlmem:"
> triggered my naming finickiness.

I agree with the subject fixup, and patch is:
Acked-by: Ben Widawsky <ben.widawsky@intel.com>

I think there can be cases made for when it might not be a specific C file that
is in the subject, but this isn't one of them.
diff mbox series

Patch

diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
index f978a046591b..8d96d009ad90 100644
--- a/drivers/cxl/cxlmem.h
+++ b/drivers/cxl/cxlmem.h
@@ -97,7 +97,6 @@  struct cxl_mbox_cmd {
  * Currently only memory devices are represented.
  *
  * @dev: The device associated with this CXL state
- * @cxlmd: Logical memory device chardev / interface
  * @regs: Parsed register blocks
  * @payload_size: Size of space for payload
  *                (CXL 2.0 8.2.8.4.3 Mailbox Capabilities Register)
@@ -124,7 +123,6 @@  struct cxl_mbox_cmd {
  */
 struct cxl_dev_state {
 	struct device *dev;
-	struct cxl_memdev *cxlmd;
 
 	struct cxl_regs regs;