| Message ID | 20211102112120.23637-1-a-govindraju@ti.com |
|---|---|
| State | Accepted |
| Commit | be24d24840ccb6f35ecd866005bf1b9498cddf97 |
| Headers | show |
| Series | phy: phy-can-transceiver: Make devm_gpiod_get optional | expand |
On 02.11.2021 16:51:20, Aswath Govindraju wrote: > In some cases the standby/enable gpio can be pulled low/high and would not > be connected to a gpio. The current driver implementation will return an > error in these cases. Therefore, make devm_gpiod_get optional. > > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> regards, Marc
On 02-11-21, 16:51, Aswath Govindraju wrote: > In some cases the standby/enable gpio can be pulled low/high and would not > be connected to a gpio. The current driver implementation will return an > error in these cases. Therefore, make devm_gpiod_get optional. Applied, thanks
diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c index c2cb93b4df71..6f3fe37dee0e 100644 --- a/drivers/phy/phy-can-transceiver.c +++ b/drivers/phy/phy-can-transceiver.c @@ -110,14 +110,14 @@ static int can_transceiver_phy_probe(struct platform_device *pdev) can_transceiver_phy->generic_phy = phy; if (drvdata->flags & CAN_TRANSCEIVER_STB_PRESENT) { - standby_gpio = devm_gpiod_get(dev, "standby", GPIOD_OUT_HIGH); + standby_gpio = devm_gpiod_get_optional(dev, "standby", GPIOD_OUT_HIGH); if (IS_ERR(standby_gpio)) return PTR_ERR(standby_gpio); can_transceiver_phy->standby_gpio = standby_gpio; } if (drvdata->flags & CAN_TRANSCEIVER_EN_PRESENT) { - enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); + enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(enable_gpio)) return PTR_ERR(enable_gpio); can_transceiver_phy->enable_gpio = enable_gpio;
In some cases the standby/enable gpio can be pulled low/high and would not be connected to a gpio. The current driver implementation will return an error in these cases. Therefore, make devm_gpiod_get optional. Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> --- drivers/phy/phy-can-transceiver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)