diff mbox series

amt: add IPV6 Kconfig dependency

Message ID 20211108111322.3852690-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 9758aba8542bb43029d077303d05df1d00a8dbb5
Delegated to: Netdev Maintainers
Headers show
Series amt: add IPV6 Kconfig dependency | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Arnd Bergmann Nov. 8, 2021, 11:12 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

This driver cannot be built-in if IPV6 is a loadable module:

x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'

Add the idiomatic Kconfig dependency that all such modules
have.

Fixes: b9022b53adad ("amt: add control plane of amt interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Taehee Yoo Nov. 8, 2021, 12:39 p.m. UTC | #1 
Hi Arnd,

On 11/8/21 8:12 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver cannot be built-in if IPV6 is a loadable module:
> 
> x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
> amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
> 
> Add the idiomatic Kconfig dependency that all such modules
> have.
> 
> Fixes: b9022b53adad ("amt: add control plane of amt interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 034dbd487c33..10506a4b66ef 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -294,6 +294,7 @@ config GTP
>   config AMT
>   	tristate "Automatic Multicast Tunneling (AMT)"
>   	depends on INET && IP_MULTICAST
> +	depends on IPV6 || !IPV6
>   	select NET_UDP_TUNNEL
>   	help
>   	  This allows one to create AMT(Automatic Multicast Tunneling)
> 

Acked-by: Taehee Yoo <ap420073@gmail.com>
patchwork-bot+netdevbpf@kernel.org Nov. 9, 2021, 2:10 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon,  8 Nov 2021 12:12:24 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver cannot be built-in if IPV6 is a loadable module:
> 
> x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
> amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
> 
> [...]

Here is the summary with links:
  - amt: add IPV6 Kconfig dependency
    https://git.kernel.org/netdev/net/c/9758aba8542b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 034dbd487c33..10506a4b66ef 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -294,6 +294,7 @@  config GTP
 config AMT
 	tristate "Automatic Multicast Tunneling (AMT)"
 	depends on INET && IP_MULTICAST
+	depends on IPV6 || !IPV6
 	select NET_UDP_TUNNEL
 	help
 	  This allows one to create AMT(Automatic Multicast Tunneling)