diff mbox series

[net] iavf: missing unlocks in iavf_watchdog_task()

Message ID 20211110081350.GI5176@kili (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series [net] iavf: missing unlocks in iavf_watchdog_task() | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 17 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Dan Carpenter Nov. 10, 2021, 8:13 a.m. UTC
This code was re-organized and there some unlocks missing now.

Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Menzel Nov. 10, 2021, 8:53 a.m. UTC | #1
Dear Dan,


Thank you for your patch.

For the future, just a nit for the commit message summary. Could you 
make it a statement by adding a verb (in imperative mood) [1].

 > iavf: Add missing unlocks in iavf_watchdog_task()


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
Dan Carpenter Nov. 10, 2021, 9:05 a.m. UTC | #2
On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:
> Dear Dan,
> 
> 
> Thank you for your patch.
> 
> For the future, just a nit for the commit message summary. Could you make it
> a statement by adding a verb (in imperative mood) [1].
> 
> > iavf: Add missing unlocks in iavf_watchdog_task()
> 

Imperative shmeritave.

When subsystems get taken over by fussy bureaucrats then I only send
them bug reports instead of patches.

regards,
dan carpenter
Paul Menzel Nov. 10, 2021, 9:27 a.m. UTC | #3
Dear Dan,


Am 10.11.21 um 10:05 schrieb Dan Carpenter:
> On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:

>> Thank you for your patch.
>>
>> For the future, just a nit for the commit message summary. Could you make it
>> a statement by adding a verb (in imperative mood) [1].
>>
>>> iavf: Add missing unlocks in iavf_watchdog_task()
> 
> Imperative shmeritave.
> 
> When subsystems get taken over by fussy bureaucrats then I only send
> them bug reports instead of patches.

It was just a wish as the standard commit messages follow that format, 
and any verb could be added. It’s not a requirement to my knowledge, and 
I do not have any authority anyway. Sorry about that, and thank you for 
your patches.


Kind regards,

Paul
Dan Carpenter Nov. 10, 2021, 9:36 a.m. UTC | #4
Yep.  Thanks.  I know.  I'm just trying to discourage those kind of
review comments.

regards,
dan carpenter
Jankowski, Konrad0 Dec. 13, 2021, 1:34 p.m. UTC | #5
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Dan Carpenter
> Sent: środa, 10 listopada 2021 09:14
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Palczewski, Mateusz
> <mateusz.palczewski@intel.com>
> Cc: Pawlak, Jakub <jakub.pawlak@intel.com>; netdev@vger.kernel.org;
> kernel-janitors@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; intel-
> wired-lan@lists.osuosl.org; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in
> iavf_watchdog_task()
> 
> This code was re-organized and there some unlocks missing now.
> 
> Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 847d67e32a54..b97f685a5cf8 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -2012,6 +2012,7 @@ static void iavf_watchdog_task(struct work_struct
> *work)

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 847d67e32a54..b97f685a5cf8 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2012,6 +2012,7 @@  static void iavf_watchdog_task(struct work_struct *work)
 		}
 		adapter->aq_required = 0;
 		adapter->current_op = VIRTCHNL_OP_UNKNOWN;
+		mutex_unlock(&adapter->crit_lock);
 		queue_delayed_work(iavf_wq,
 				   &adapter->watchdog_task,
 				   msecs_to_jiffies(10));
@@ -2042,9 +2043,8 @@  static void iavf_watchdog_task(struct work_struct *work)
 			iavf_detect_recover_hung(&adapter->vsi);
 		break;
 	case __IAVF_REMOVE:
-		mutex_unlock(&adapter->crit_lock);
-		return;
 	default:
+		mutex_unlock(&adapter->crit_lock);
 		return;
 	}