| Message ID | 20211111091123.50853-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cb0ad82ee216268f298a86067f76271f51ba3d91 |
| Headers | show |
| Series | ARM: s3c: include header for prototype of s3c2410_modify_misccr | expand |
On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Include the header with prototype of s3c2410_modify_misccr to fix W=1 > warning: > > arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: > no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Thank you for fixing it, Acked-by: Arnd Bergmann <arnd@arndb.de> If you like, I can put it into the fixes branch of the soc tree directly, otherwise I expect you'll send it in a pull request later. Arnd
On 11/11/2021 10:46, Arnd Bergmann wrote: > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> >> Include the header with prototype of s3c2410_modify_misccr to fix W=1 >> warning: >> >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] >> >> Reported-by: kernel test robot <lkp@intel.com> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > Thank you for fixing it, > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > If you like, I can put it into the fixes branch of the soc tree directly, > otherwise I expect you'll send it in a pull request later. It's not a serious bug and was there since long time, so maybe let's send it via regular pull request. Best regards, Krzysztof
Hi Krzysztof, On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Include the header with prototype of s3c2410_modify_misccr to fix W=1 > warning: > > arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: > no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm/mach-s3c/gpio-samsung.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c > index 76ef415789f2..fda2c01f5a08 100644 > --- a/arch/arm/mach-s3c/gpio-samsung.c > +++ b/arch/arm/mach-s3c/gpio-samsung.c > @@ -35,6 +35,7 @@ > #include "gpio-core.h" > #include "gpio-cfg.h" > #include "gpio-cfg-helpers.h" > +#include "hardware-s3c24xx.h" > #include "pm.h" > > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip, > -- > 2.32.0 >
On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 11/11/2021 10:46, Arnd Bergmann wrote: > > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@canonical.com> wrote: > >> > >> Include the header with prototype of s3c2410_modify_misccr to fix W=1 > >> warning: > >> > >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: > >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] > >> > >> Reported-by: kernel test robot <lkp@intel.com> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > > > Thank you for fixing it, > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > If you like, I can put it into the fixes branch of the soc tree directly, > > otherwise I expect you'll send it in a pull request later. > > It's not a serious bug and was there since long time, so maybe let's > send it via regular pull request. Ok, sounds good. I was worried for a bit that this would break builds with CONFIG_WERROR, but of course that is already broken in many ways with W=1. Arnd
On Thu, 11 Nov 2021 10:11:23 +0100, Krzysztof Kozlowski wrote: > Include the header with prototype of s3c2410_modify_misccr to fix W=1 > warning: > > arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: > no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] > > > [...] Applied, thanks! [1/1] ARM: s3c: include header for prototype of s3c2410_modify_misccr commit: 90dc0df9168b6c1ddb339481b440d7c13cc4417c Best regards,
diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c index 76ef415789f2..fda2c01f5a08 100644 --- a/arch/arm/mach-s3c/gpio-samsung.c +++ b/arch/arm/mach-s3c/gpio-samsung.c @@ -35,6 +35,7 @@ #include "gpio-core.h" #include "gpio-cfg.h" #include "gpio-cfg-helpers.h" +#include "hardware-s3c24xx.h" #include "pm.h" int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
Include the header with prototype of s3c2410_modify_misccr to fix W=1 warning: arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm/mach-s3c/gpio-samsung.c | 1 + 1 file changed, 1 insertion(+)