[v5,0/4] netfs, 9p, afs, ceph: Support folios, at least partially

Message

David Howells Nov. 10, 2021, 9:07 p.m. UTC

Here's a set of patches to convert netfs, 9p and afs to use folios and to
provide sufficient conversion for ceph that it can continue to use the
netfs library.  Jeff Layton is working on fully converting ceph.

This has been rebased on to the 9p merge in Linus's tree[5] so that it has
access to both the 9p conversion to fscache and folios.

Changes
=======
ver #5:
 - Got rid of the folio_endio bits again as Willy changed his mind and
   would rather I inlined the code directly instead.

ver #4:
 - Detached and sent the afs symlink split patch separately.
 - Handed the 9p netfslibisation patch off to Dominique Martinet.
 - Added a patch to foliate page_endio().
 - Fixed a bug in afs_redirty_page() whereby it didn't set the next page
   index in the loop and returned too early.
 - Simplified a check in v9fs_vfs_write_folio_locked()[4].
 - Undid a change to afs_symlink_readpage()[4].
 - Used offset_in_folio() in afs_write_end()[4].
 - Rebased on 9p-folio merge upstream[5].

ver #3:
 - Rebased on upstream as folios have been pulled.
 - Imported a patch to convert 9p to netfslib from my
   fscache-remove-old-api branch[3].
 - Foliated netfslib.

ver #2:
 - Reorder the patches to put both non-folio afs patches to the front.
 - Use page_offset() rather than manual calculation[1].
 - Fix folio_inode() to directly access the inode[2].

David

Link: https://lore.kernel.org/r/YST/[e-mail]/ [1]
Link: https://lore.kernel.org/r/[e-mail]/ [2]
Link: https://lore.kernel.org/r/[e-mail]/ [3]
Link: https://lore.kernel.org/r/YYKa3bfQZxK5/[e-mail]/ [4]
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f89ce84bc33330607a782e47a8b19406ed109b15 [5]
Link: https://lore.kernel.org/r/[e-mail]/ # v0
Link: https://lore.kernel.org/r/[e-mail]/ # v1
Link: https://lore.kernel.org/r/[e-mail]/ # v2
Link: https://lore.kernel.org/r/[e-mail]>/ # v3
Link: https://lore.kernel.org/r/[e-mail]/ # v4
---
David Howells (4):
      folio: Add a function to change the private data attached to a folio
      folio: Add a function to get the host inode for a folio
      netfs, 9p, afs, ceph: Use folios
      afs: Use folios in directory handling


 fs/9p/vfs_addr.c           |  83 +++++----
 fs/9p/vfs_file.c           |  20 +--
 fs/afs/dir.c               | 229 ++++++++++--------------
 fs/afs/dir_edit.c          | 154 ++++++++--------
 fs/afs/file.c              |  70 ++++----
 fs/afs/internal.h          |  46 ++---
 fs/afs/write.c             | 347 ++++++++++++++++++-------------------
 fs/ceph/addr.c             |  80 +++++----
 fs/netfs/read_helper.c     | 165 +++++++++---------
 include/linux/netfs.h      |  12 +-
 include/linux/pagemap.h    |  14 ++
 include/trace/events/afs.h |  21 +--
 mm/page-writeback.c        |   2 +-
 13 files changed, 617 insertions(+), 626 deletions(-)



Tested-by: Jeff Layton <[e-mail]>
Tested-by: Dominique Martinet <[e-mail]>
Tested-by: [e-mail]

Comments

Dominique Martinet Nov. 11, 2021, 2:28 p.m. UTC | #1

David Howells wrote on Wed, Nov 10, 2021 at 09:07:56PM +0000:
> Here's a set of patches to convert netfs, 9p and afs to use folios and to
> provide sufficient conversion for ceph that it can continue to use the
> netfs library.  Jeff Layton is working on fully converting ceph.
> 
> This has been rebased on to the 9p merge in Linus's tree[5] so that it has
> access to both the 9p conversion to fscache and folios.

Ran basic tests on 9p with this; it'd probably deserve a bit more
soak-in but at least doesn't seem to break anything obvious:
(Re-)Tested-by: Dominique Martinet <[e-mail]>

Jeffrey E Altman Nov. 11, 2021, 3:45 p.m. UTC | #2

On 11/10/2021 4:09 PM, David Howells ([e-mail]) wrote:
> Convert the AFS directory handling code to use folios.
>
> With these changes, afs passes -g quick xfstests.
>
> Signed-off-by: David Howells <[e-mail]>
> Tested-by: [e-mail]
> cc: Matthew Wilcox (Oracle) <[e-mail]>
> cc: Jeff Layton <[e-mail]>
> cc: Marc Dionne <[e-mail]>
> cc: [e-mail]
> cc: [e-mail]
> Link: https://lore.kernel.org/r/[e-mail]/
> Link: https://lore.kernel.org/r/[e-mail]/
> Link: https://lore.kernel.org/r/[e-mail]/ # v2
> Link: https://lore.kernel.org/r/[e-mail]/ # v3
> Link: https://lore.kernel.org/r/CAH2r5mtECQA6K_OGgU=[e-mail]/ # v3
> Link: https://lore.kernel.org/r/[e-mail]/ # v4
Patch v5

Tested-by: [e-mail]