| Message ID | 20211110105922.217895-16-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Enable Qualcomm Crypto Engine on sm8150 & sm8250 | expand |
Hi Bhupesh, On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > Since we decided to use soc specific compatibles for describing > the qce crypto IP nodes in the device-trees, adapt the driver > now to handle the same. > > Keep the old deprecated compatible strings still in the driver, > to ensure backward compatibility. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > drivers/crypto/qce/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 89d9c01ba009..dd2604f5ce6a 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -297,8 +297,12 @@ static int qce_crypto_remove(struct platform_device *pdev) > } > > static const struct of_device_id qce_crypto_of_match[] = { > + /* Following two entries are deprecated (kept only for backward compatibility) */ > { .compatible = "qcom,crypto-v5.1", }, > { .compatible = "qcom,crypto-v5.4", }, > + /* Add compatible strings as per updated dt-bindings, here: */ > + { .compatible = "qcom,ipq6018-qce", }, > + { .compatible = "qcom,sdm845-qce", }, > {} > }; > MODULE_DEVICE_TABLE(of, qce_crypto_of_match); > and two more compatibles should be added to the list, see my review comment on v5 11/22. -- Best wishes, Vladimir
Hi Vladimir, On Fri, 12 Nov 2021 at 16:06, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote: > > Hi Bhupesh, > > On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > > Since we decided to use soc specific compatibles for describing > > the qce crypto IP nodes in the device-trees, adapt the driver > > now to handle the same. > > > > Keep the old deprecated compatible strings still in the driver, > > to ensure backward compatibility. > > > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > drivers/crypto/qce/core.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 89d9c01ba009..dd2604f5ce6a 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -297,8 +297,12 @@ static int qce_crypto_remove(struct platform_device *pdev) > > } > > > > static const struct of_device_id qce_crypto_of_match[] = { > > + /* Following two entries are deprecated (kept only for backward compatibility) */ > > { .compatible = "qcom,crypto-v5.1", }, > > { .compatible = "qcom,crypto-v5.4", }, > > + /* Add compatible strings as per updated dt-bindings, here: */ > > + { .compatible = "qcom,ipq6018-qce", }, > > + { .compatible = "qcom,sdm845-qce", }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, qce_crypto_of_match); > > > > and two more compatibles should be added to the list, see my review > comment on v5 11/22. Ok, I will fix this in v6. Regards, Bhupesh
diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c index 89d9c01ba009..dd2604f5ce6a 100644 --- a/drivers/crypto/qce/core.c +++ b/drivers/crypto/qce/core.c @@ -297,8 +297,12 @@ static int qce_crypto_remove(struct platform_device *pdev) } static const struct of_device_id qce_crypto_of_match[] = { + /* Following two entries are deprecated (kept only for backward compatibility) */ { .compatible = "qcom,crypto-v5.1", }, { .compatible = "qcom,crypto-v5.4", }, + /* Add compatible strings as per updated dt-bindings, here: */ + { .compatible = "qcom,ipq6018-qce", }, + { .compatible = "qcom,sdm845-qce", }, {} }; MODULE_DEVICE_TABLE(of, qce_crypto_of_match);
Since we decided to use soc specific compatibles for describing the qce crypto IP nodes in the device-trees, adapt the driver now to handle the same. Keep the old deprecated compatible strings still in the driver, to ensure backward compatibility. Cc: Thara Gopinath <thara.gopinath@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- drivers/crypto/qce/core.c | 4 ++++ 1 file changed, 4 insertions(+)