| Message ID | 20211105143550.1783528-3-demonsingur@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add AD74413R driver | expand |
On Fri, 05 Nov 2021 16:35:49 +0200, Cosmin Tanislav wrote: > Add device tree bindings for AD74413R. > > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com> > --- > .../bindings/iio/addac/adi,ad74413r.yaml | 153 ++++++++++++++++++ > include/dt-bindings/iio/addac/adi,ad74413r.h | 21 +++ > 2 files changed, 174 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > create mode 100644 include/dt-bindings/iio/addac/adi,ad74413r.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml: properties:adi,rsense-resistance-ohms: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml: ignoring, error in schema: properties: adi,rsense-resistance-ohms warning: no schema found in file: ./Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml Error: Documentation/devicetree/bindings/iio/addac/adi,ad74413r.example.dts:23.32-33 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/iio/addac/adi,ad74413r.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1441: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1551417 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, 5 Nov 2021 16:35:49 +0200 Cosmin Tanislav <demonsingur@gmail.com> wrote: > Add device tree bindings for AD74413R. > > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com> Hi Cosmin, Other than the unnecessary $ref that Rob's scripts already pointed out this looks good to me. Thanks, Jonathan > --- > .../bindings/iio/addac/adi,ad74413r.yaml | 153 ++++++++++++++++++ > include/dt-bindings/iio/addac/adi,ad74413r.h | 21 +++ > 2 files changed, 174 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > create mode 100644 include/dt-bindings/iio/addac/adi,ad74413r.h > > diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > new file mode 100644 > index 000000000000..a1add5a2bce2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > @@ -0,0 +1,153 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/addac/adi,ad74413r.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD74413R/AD74412R device > + > +maintainers: > + - Cosmin Tanislav <cosmin.tanislav@analog.com> > + > +description: | > + The AD74413R and AD74412R are quad-channel software configurable input/output > + solutions for building and process control applications. They contain > + functionality for analog output, analog input, digital input, resistance > + temperature detector, and thermocouple measurements integrated > + into a single chip solution with an SPI interface. > + The devices feature a 16-bit ADC and four configurable 13-bit DACs to provide > + four configurable input/output channels and a suite of diagnostic functions. > + > +properties: > + compatible: > + enum: > + - adi,ad74412r > + - adi,ad74413r > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + spi-max-frequency: > + maximum: 1000000 > + > + spi-cpol: true > + > + interrupts: > + maxItems: 1 > + > + refin-supply: true > + > + adi,rsense-resistance-ohms: > + $ref: /schemas/types.yaml#/definitions/uint32 As Rob's scripts pointed out: Now you have the ending specifying the units there is not need to also have $ref. The dt-schema special cases a bunch of unit types for us. > + description: > + RSense resistance values in Ohms. > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + - spi-cpol > + - refin-supply > + - adi,rsense-resistance-ohm > + > +additionalProperties: false > + > +patternProperties: > + "^channel@[0-3]$": > + type: object > + description: Represents the external channels which are connected to the device. > + > + properties: > + reg: > + description: | > + The channel number. It can have up to 4 channels numbered from 0 to 3. > + minimum: 0 > + maximum: 3 > + > + adi,ch-func: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Channel function. > + HART functions are not supported on AD74412R. > + 0 - CH_FUNC_HIGH_IMPEDANCE > + 1 - CH_FUNC_VOLTAGE_OUTPUT > + 2 - CH_FUNC_CURRENT_OUTPUT > + 3 - CH_FUNC_VOLTAGE_INPUT > + 4 - CH_FUNC_CURRENT_INPUT_EXT_POWER > + 5 - CH_FUNC_CURRENT_INPUT_LOOP_POWER > + 6 - CH_FUNC_RESISTANCE_INPUT > + 7 - CH_FUNC_DIGITAL_INPUT_LOGIC > + 8 - CH_FUNC_DIGITAL_INPUT_LOOP_POWER > + 9 - CH_FUNC_CURRENT_INPUT_EXT_POWER_HART > + 10 - CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART > + minimum: 0 > + maximum: 10 > + default: 0 > + > + adi,gpo-comparator: > + type: boolean > + description: | > + Whether to configure GPO as a comparator or not. > + When not configured as a comparator, the GPO will be treated as an > + output-only GPIO. > + > + required: > + - reg > + > +examples: > + - | > + spi0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cs-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > + status = "okay"; > + > + ad74413r@0 { > + compatible = "adi,ad74413r"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cpol; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + interrupt-parent = <&gpio>; > + interrupts = <26 0>; > + > + refin-supply = <&ad74413r_refin>; > + adi,rsense-resistance-ohm = <100>; > + > + channel@0 { > + reg = <0>; > + > + adi,ch-func = <CH_FUNC_VOLTAGE_OUTPUT>; > + }; > + > + channel@1 { > + reg = <1>; > + > + adi,ch-func = <CH_FUNC_CURRENT_OUTPUT>; > + }; > + > + channel@2 { > + reg = <2>; > + > + adi,ch-func = <CH_FUNC_DIGITAL_INPUT_LOGIC>; > + adi,gpo-comparator; > + }; > + > + channel@3 { > + reg = <3>; > + > + adi,ch-func = <CH_FUNC_CURRENT_INPUT_EXT_POWER>; > + }; > + }; > + }; > +... > diff --git a/include/dt-bindings/iio/addac/adi,ad74413r.h b/include/dt-bindings/iio/addac/adi,ad74413r.h > new file mode 100644 > index 000000000000..a43b010f974f > --- /dev/null > +++ b/include/dt-bindings/iio/addac/adi,ad74413r.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _DT_BINDINGS_ADI_AD74413R_H > +#define _DT_BINDINGS_ADI_AD74413R_H > + > +#define CH_FUNC_HIGH_IMPEDANCE 0x0 > +#define CH_FUNC_VOLTAGE_OUTPUT 0x1 > +#define CH_FUNC_CURRENT_OUTPUT 0x2 > +#define CH_FUNC_VOLTAGE_INPUT 0x3 > +#define CH_FUNC_CURRENT_INPUT_EXT_POWER 0x4 > +#define CH_FUNC_CURRENT_INPUT_LOOP_POWER 0x5 > +#define CH_FUNC_RESISTANCE_INPUT 0x6 > +#define CH_FUNC_DIGITAL_INPUT_LOGIC 0x7 > +#define CH_FUNC_DIGITAL_INPUT_LOOP_POWER 0x8 > +#define CH_FUNC_CURRENT_INPUT_EXT_POWER_HART 0x9 > +#define CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART 0xA > + > +#define CH_FUNC_MIN CH_FUNC_HIGH_IMPEDANCE > +#define CH_FUNC_MAX CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART > + > +#endif /* _DT_BINDINGS_ADI_AD74413R_H */
diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml new file mode 100644 index 000000000000..a1add5a2bce2 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml @@ -0,0 +1,153 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/addac/adi,ad74413r.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD74413R/AD74412R device + +maintainers: + - Cosmin Tanislav <cosmin.tanislav@analog.com> + +description: | + The AD74413R and AD74412R are quad-channel software configurable input/output + solutions for building and process control applications. They contain + functionality for analog output, analog input, digital input, resistance + temperature detector, and thermocouple measurements integrated + into a single chip solution with an SPI interface. + The devices feature a 16-bit ADC and four configurable 13-bit DACs to provide + four configurable input/output channels and a suite of diagnostic functions. + +properties: + compatible: + enum: + - adi,ad74412r + - adi,ad74413r + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + spi-max-frequency: + maximum: 1000000 + + spi-cpol: true + + interrupts: + maxItems: 1 + + refin-supply: true + + adi,rsense-resistance-ohms: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + RSense resistance values in Ohms. + +required: + - compatible + - reg + - spi-max-frequency + - spi-cpol + - refin-supply + - adi,rsense-resistance-ohm + +additionalProperties: false + +patternProperties: + "^channel@[0-3]$": + type: object + description: Represents the external channels which are connected to the device. + + properties: + reg: + description: | + The channel number. It can have up to 4 channels numbered from 0 to 3. + minimum: 0 + maximum: 3 + + adi,ch-func: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Channel function. + HART functions are not supported on AD74412R. + 0 - CH_FUNC_HIGH_IMPEDANCE + 1 - CH_FUNC_VOLTAGE_OUTPUT + 2 - CH_FUNC_CURRENT_OUTPUT + 3 - CH_FUNC_VOLTAGE_INPUT + 4 - CH_FUNC_CURRENT_INPUT_EXT_POWER + 5 - CH_FUNC_CURRENT_INPUT_LOOP_POWER + 6 - CH_FUNC_RESISTANCE_INPUT + 7 - CH_FUNC_DIGITAL_INPUT_LOGIC + 8 - CH_FUNC_DIGITAL_INPUT_LOOP_POWER + 9 - CH_FUNC_CURRENT_INPUT_EXT_POWER_HART + 10 - CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART + minimum: 0 + maximum: 10 + default: 0 + + adi,gpo-comparator: + type: boolean + description: | + Whether to configure GPO as a comparator or not. + When not configured as a comparator, the GPO will be treated as an + output-only GPIO. + + required: + - reg + +examples: + - | + spi0 { + #address-cells = <1>; + #size-cells = <0>; + + cs-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; + status = "okay"; + + ad74413r@0 { + compatible = "adi,ad74413r"; + reg = <0>; + spi-max-frequency = <1000000>; + spi-cpol; + + #address-cells = <1>; + #size-cells = <0>; + + interrupt-parent = <&gpio>; + interrupts = <26 0>; + + refin-supply = <&ad74413r_refin>; + adi,rsense-resistance-ohm = <100>; + + channel@0 { + reg = <0>; + + adi,ch-func = <CH_FUNC_VOLTAGE_OUTPUT>; + }; + + channel@1 { + reg = <1>; + + adi,ch-func = <CH_FUNC_CURRENT_OUTPUT>; + }; + + channel@2 { + reg = <2>; + + adi,ch-func = <CH_FUNC_DIGITAL_INPUT_LOGIC>; + adi,gpo-comparator; + }; + + channel@3 { + reg = <3>; + + adi,ch-func = <CH_FUNC_CURRENT_INPUT_EXT_POWER>; + }; + }; + }; +... diff --git a/include/dt-bindings/iio/addac/adi,ad74413r.h b/include/dt-bindings/iio/addac/adi,ad74413r.h new file mode 100644 index 000000000000..a43b010f974f --- /dev/null +++ b/include/dt-bindings/iio/addac/adi,ad74413r.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _DT_BINDINGS_ADI_AD74413R_H +#define _DT_BINDINGS_ADI_AD74413R_H + +#define CH_FUNC_HIGH_IMPEDANCE 0x0 +#define CH_FUNC_VOLTAGE_OUTPUT 0x1 +#define CH_FUNC_CURRENT_OUTPUT 0x2 +#define CH_FUNC_VOLTAGE_INPUT 0x3 +#define CH_FUNC_CURRENT_INPUT_EXT_POWER 0x4 +#define CH_FUNC_CURRENT_INPUT_LOOP_POWER 0x5 +#define CH_FUNC_RESISTANCE_INPUT 0x6 +#define CH_FUNC_DIGITAL_INPUT_LOGIC 0x7 +#define CH_FUNC_DIGITAL_INPUT_LOOP_POWER 0x8 +#define CH_FUNC_CURRENT_INPUT_EXT_POWER_HART 0x9 +#define CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART 0xA + +#define CH_FUNC_MIN CH_FUNC_HIGH_IMPEDANCE +#define CH_FUNC_MAX CH_FUNC_CURRENT_INPUT_LOOP_POWER_HART + +#endif /* _DT_BINDINGS_ADI_AD74413R_H */
Add device tree bindings for AD74413R. Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com> --- .../bindings/iio/addac/adi,ad74413r.yaml | 153 ++++++++++++++++++ include/dt-bindings/iio/addac/adi,ad74413r.h | 21 +++ 2 files changed, 174 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml create mode 100644 include/dt-bindings/iio/addac/adi,ad74413r.h