[v3] mips: bcm63xx: add support for clk_get_parent()

Commit Message

Randy Dunlap Nov. 14, 2021, 4:34 p.m. UTC

BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
clk_get_parent(), so add a simple implementation of that
function so that callers of it will build without errors.

Fixes these build errors:

mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'

Signed-off-by: Randy Dunlap <[e-mail]>
Reported-by: kernel test robot <[e-mail]>
Cc: Artur Rojek <[e-mail]>
Cc: Paul Cercueil <[e-mail]>
Cc: [e-mail]
Cc: Jonathan Cameron <[e-mail]>
Cc: Lars-Peter Clausen <[e-mail]>
Cc: [e-mail]
Cc: Florian Fainelli <[e-mail]>
Cc: Andy Shevchenko <[e-mail]>
Cc: Russell King <[e-mail]>
Cc: [e-mail]
Cc: Jonas Gorski <[e-mail]>
---
v1 and v2 were:
[PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

 arch/mips/bcm63xx/clk.c |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andy Shevchenko Nov. 14, 2021, 4:40 p.m. UTC | #1

On Sun, Nov 14, 2021 at 6:34 PM Randy Dunlap <[e-mail]> wrote:
>
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'

Some nit-picks below.
Otherwise looks good to me,
Reviewed-by: Andy Shevchenko <[e-mail]>

Suggested-by?

> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Cc: Artur Rojek <[e-mail]>
> Cc: Paul Cercueil <[e-mail]>
> Cc: [e-mail]
> Cc: Jonathan Cameron <[e-mail]>
> Cc: Lars-Peter Clausen <[e-mail]>
> Cc: [e-mail]
> Cc: Florian Fainelli <[e-mail]>
> Cc: Andy Shevchenko <[e-mail]>
> Cc: Russell King <[e-mail]>
> Cc: [e-mail]
> Cc: Jonas Gorski <[e-mail]>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors

> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

Not sure why it's here. What does (the location of) this tag mean?

>  arch/mips/bcm63xx/clk.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>
>  EXPORT_SYMBOL(clk_disable);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +       return NULL;
> +}

> +

Perhaps it's not needed even if the rest have it (I mean blank line).

> +EXPORT_SYMBOL(clk_get_parent);
> +
>  unsigned long clk_get_rate(struct clk *clk)
>  {
>         if (!clk)

Jonathan Cameron Nov. 14, 2021, 4:59 p.m. UTC | #2

On Sun, 14 Nov 2021 08:34:44 -0800
Randy Dunlap <[e-mail]> wrote:

> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
> 
> Fixes these build errors:
> 
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>

Acked-by: Jonathan Cameron <[e-mail]>

I wonder a bit if it makes sense to fix only the ones we hit given there
look to be other missing definitions in this subarch.
clk_has_parent() for example appears to also be missing.

Do we have the same issue with mips/lantiq?

Jonathan


> Cc: Artur Rojek <[e-mail]>
> Cc: Paul Cercueil <[e-mail]>
> Cc: [e-mail]
> Cc: Jonathan Cameron <[e-mail]>
> Cc: Lars-Peter Clausen <[e-mail]>
> Cc: [e-mail]
> Cc: Florian Fainelli <[e-mail]>
> Cc: Andy Shevchenko <[e-mail]>
> Cc: Russell King <[e-mail]>
> Cc: [e-mail]
> Cc: Jonas Gorski <[e-mail]>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
> 
>  arch/mips/bcm63xx/clk.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>  
>  EXPORT_SYMBOL(clk_disable);
>  
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +	return NULL;
> +}
> +
> +EXPORT_SYMBOL(clk_get_parent);
> +
>  unsigned long clk_get_rate(struct clk *clk)
>  {
>  	if (!clk)

Russell King (Oracle) Nov. 14, 2021, 10:55 p.m. UTC | #3

On Sun, Nov 14, 2021 at 08:34:44AM -0800, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
> 
> Fixes these build errors:
> 
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>

Acked-by: Russell King (Oracle) <[e-mail]>

Thanks.

Randy Dunlap Nov. 14, 2021, 11:58 p.m. UTC | #4

On 11/14/21 8:59 AM, Jonathan Cameron wrote:
> On Sun, 14 Nov 2021 08:34:44 -0800
> Randy Dunlap <[e-mail]> wrote:
> 
>> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
>> clk_get_parent(), so add a simple implementation of that
>> function so that callers of it will build without errors.
>>
>> Fixes these build errors:
>>
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>>
>> Signed-off-by: Randy Dunlap <[e-mail]>
>> Reported-by: kernel test robot <[e-mail]>
> 
> Acked-by: Jonathan Cameron <[e-mail]>
> 
> I wonder a bit if it makes sense to fix only the ones we hit given there
> look to be other missing definitions in this subarch.
> clk_has_parent() for example appears to also be missing.

I haven't seen any failures for clk_has_parent().

I'm not actively looking for build errors; I'm just fixing
reported problems (usually and in this case).
There are plenty of them being reported without me having
to go looking for more.

> Do we have the same issue with mips/lantiq?

Yes, now that you made me look. :)
Now I'll have to send a patch for that subarch also.

Randy Dunlap Nov. 15, 2021, 12:18 a.m. UTC | #5

On 11/14/21 8:40 AM, Andy Shevchenko wrote:
> On Sun, Nov 14, 2021 at 6:34 PM Randy Dunlap <[e-mail]> wrote:
>>
>> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
>> clk_get_parent(), so add a simple implementation of that
>> function so that callers of it will build without errors.
>>
>> Fixes these build errors:
>>
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Some nit-picks below.
> Otherwise looks good to me,
> Reviewed-by: Andy Shevchenko <[e-mail]>
> 
> Suggested-by?

Yes, I'll add Russell for that.

>> Signed-off-by: Randy Dunlap <[e-mail]>
>> Reported-by: kernel test robot <[e-mail]>
>> Cc: Artur Rojek <[e-mail]>
>> Cc: Paul Cercueil <[e-mail]>
>> Cc: [e-mail]
>> Cc: Jonathan Cameron <[e-mail]>
>> Cc: Lars-Peter Clausen <[e-mail]>
>> Cc: [e-mail]
>> Cc: Florian Fainelli <[e-mail]>
>> Cc: Andy Shevchenko <[e-mail]>
>> Cc: Russell King <[e-mail]>
>> Cc: [e-mail]
>> Cc: Jonas Gorski <[e-mail]>
>> ---
>> v1 and v2 were:
>> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
> 
>> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
> 
> Not sure why it's here. What does (the location of) this tag mean?

Yesterday I didn't see what Fixes: tag I should use,
but after looking again, it looks like I should use
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs."


> 
>>   arch/mips/bcm63xx/clk.c |    7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
>> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
>> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>>
>>   EXPORT_SYMBOL(clk_disable);
>>
>> +struct clk *clk_get_parent(struct clk *clk)
>> +{
>> +       return NULL;
>> +}
> 
>> +
> 
> Perhaps it's not needed even if the rest have it (I mean blank line).

Sure, I'll drop it. It was for file consistency,
but it's not a big deal either way.

>> +EXPORT_SYMBOL(clk_get_parent);
>> +
>>   unsigned long clk_get_rate(struct clk *clk)
>>   {
>>          if (!clk)
> 

Thanks.

Patch

--- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
+++ linux-next-20211112/arch/mips/bcm63xx/clk.c
@@ -381,6 +381,13 @@  void clk_disable(struct clk *clk)
 
 EXPORT_SYMBOL(clk_disable);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+
+EXPORT_SYMBOL(clk_get_parent);
+
 unsigned long clk_get_rate(struct clk *clk)
 {
 	if (!clk)