| Message ID | 20211112145352.1125971-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e99fa4230fa89f9e76073dd6af3dd85c33ba70b8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: vsc73xxx: Make vsc73xx_remove() return void | expand |
On Fri, Nov 12, 2021 at 03:53:52PM +0100, Uwe Kleine-König wrote: > vsc73xx_remove() returns zero unconditionally and no caller checks the > returned value. So convert the function to return no value. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 12 Nov 2021 15:53:52 +0100 you wrote: > vsc73xx_remove() returns zero unconditionally and no caller checks the > returned value. So convert the function to return no value. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > [...] Here is the summary with links: - [net-next] net: dsa: vsc73xxx: Make vsc73xx_remove() return void https://git.kernel.org/netdev/net-next/c/e99fa4230fa8 You are awesome, thank you!
diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index a4b1447ff055..4c18f619ec02 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -1216,12 +1216,10 @@ int vsc73xx_probe(struct vsc73xx *vsc) } EXPORT_SYMBOL(vsc73xx_probe); -int vsc73xx_remove(struct vsc73xx *vsc) +void vsc73xx_remove(struct vsc73xx *vsc) { dsa_unregister_switch(vsc->ds); gpiod_set_value(vsc->reset, 1); - - return 0; } EXPORT_SYMBOL(vsc73xx_remove); diff --git a/drivers/net/dsa/vitesse-vsc73xx.h b/drivers/net/dsa/vitesse-vsc73xx.h index 30b951504e65..30b1f0a36566 100644 --- a/drivers/net/dsa/vitesse-vsc73xx.h +++ b/drivers/net/dsa/vitesse-vsc73xx.h @@ -26,5 +26,5 @@ struct vsc73xx_ops { int vsc73xx_is_addr_valid(u8 block, u8 subblock); int vsc73xx_probe(struct vsc73xx *vsc); -int vsc73xx_remove(struct vsc73xx *vsc); +void vsc73xx_remove(struct vsc73xx *vsc); void vsc73xx_shutdown(struct vsc73xx *vsc);
vsc73xx_remove() returns zero unconditionally and no caller checks the returned value. So convert the function to return no value. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, this is the successor of a patch I sent earlier[1], only doing the safe and undisputed part. Best regards Uwe [1] net: dsa: Some cleanups in remove code https://lore.kernel.org/r/20211109113921.1020311-1-u.kleine-koenig@pengutronix.de drivers/net/dsa/vitesse-vsc73xx-core.c | 4 +--- drivers/net/dsa/vitesse-vsc73xx.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) base-commit: 5833291ab6de9c3e2374336b51c814e515e8f3a5