[v4] mips: bcm63xx: add support for clk_get_parent()

Commit Message

Randy Dunlap Nov. 15, 2021, 12:42 a.m. UTC

BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
clk_get_parent(), so add a simple implementation of that
function so that callers of it will build without errors.

Fixes these build errors:

mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'

Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
Signed-off-by: Randy Dunlap <[e-mail]>
Reported-by: kernel test robot <[e-mail]>
Suggested-by: Russell King (Oracle) <[e-mail]>
Cc: Artur Rojek <[e-mail]>
Cc: Paul Cercueil <[e-mail]>
Cc: [e-mail]
Cc: Jonathan Cameron <[e-mail]>
Cc: Lars-Peter Clausen <[e-mail]>
Cc: [e-mail]
Cc: Florian Fainelli <[e-mail]>
Cc: Andy Shevchenko <[e-mail]>
Cc: Russell King <[e-mail]>
Cc: [e-mail]
Cc: Jonas Gorski <[e-mail]>
Reviewed-by: Andy Shevchenko <[e-mail]>
Acked-by: Jonathan Cameron <[e-mail]>
Acked-by: Russell King (Oracle) <[e-mail]>
---
v1 and v2 were:
[PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
  (limiting this driver to MACH_INGENIC in Kconfig)
v3: add clk_get_parent() to arch/mips/bcm63xx/clk.c
v4:
  add Fixes:, Suggested-by:, Reviewed-by: Acked-by:
  drop blank line between function and EXPORT_SYMBOL(); (Andy)

 arch/mips/bcm63xx/clk.c |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Florian Fainelli Nov. 15, 2021, 4:18 a.m. UTC | #1

On 11/14/2021 4:42 PM, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
> 
> Fixes these build errors:
> 
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Suggested-by: Russell King (Oracle) <[e-mail]>
> Cc: Artur Rojek <[e-mail]>
> Cc: Paul Cercueil <[e-mail]>
> Cc: [e-mail]
> Cc: Jonathan Cameron <[e-mail]>
> Cc: Lars-Peter Clausen <[e-mail]>
> Cc: [e-mail]
> Cc: Florian Fainelli <[e-mail]>
> Cc: Andy Shevchenko <[e-mail]>
> Cc: Russell King <[e-mail]>
> Cc: [e-mail]
> Cc: Jonas Gorski <[e-mail]>
> Reviewed-by: Andy Shevchenko <[e-mail]>
> Acked-by: Jonathan Cameron <[e-mail]>
> Acked-by: Russell King (Oracle) <[e-mail]>

Acked-by: Florian Fainelli <[e-mail]>

Andy Shevchenko Nov. 15, 2021, 10:56 a.m. UTC | #2

On Mon, Nov 15, 2021 at 2:42 AM Randy Dunlap <[e-mail]> wrote:

Just couple of side notes on the same topic (dropped people from Cc,
just MLs are left):

> Suggested-by: Russell King (Oracle) <[e-mail]>

> Cc: Jonathan Cameron <[e-mail]>

> Cc: Andy Shevchenko <[e-mail]>
> Cc: Russell King <[e-mail]>

> Reviewed-by: Andy Shevchenko <[e-mail]>
> Acked-by: Jonathan Cameron <[e-mail]>
> Acked-by: Russell King (Oracle) <[e-mail]>

1/ `git format-patch`/`git send-email` will create the Cc list from
all known tags, hence no need to repeat people in Cc.
2/ Consider to use --cc and --to to avoid burden on the git history
(sometimes people want to see it on mobile devices).

For myself I wrote the script [1] to give me some smartness. Maybe you
can find some ideas inside its implementation.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

Randy Dunlap Nov. 16, 2021, 6:19 a.m. UTC | #3

On 11/15/21 2:56 AM, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 2:42 AM Randy Dunlap <[e-mail]> wrote:
> 
> Just couple of side notes on the same topic (dropped people from Cc,
> just MLs are left):
> 
>> Suggested-by: Russell King (Oracle) <[e-mail]>
> 
>> Cc: Jonathan Cameron <[e-mail]>
> 
>> Cc: Andy Shevchenko <[e-mail]>
>> Cc: Russell King <[e-mail]>
> 
>> Reviewed-by: Andy Shevchenko <[e-mail]>
>> Acked-by: Jonathan Cameron <[e-mail]>
>> Acked-by: Russell King (Oracle) <[e-mail]>
> 
> 1/ `git format-patch`/`git send-email` will create the Cc list from
> all known tags, hence no need to repeat people in Cc.
> 2/ Consider to use --cc and --to to avoid burden on the git history
> (sometimes people want to see it on mobile devices).
> 
> For myself I wrote the script [1] to give me some smartness. Maybe you
> can find some ideas inside its implementation.
> 
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

OK, I'll look into that.

Thanks.

Thomas Bogendoerfer Nov. 16, 2021, 8:46 a.m. UTC | #4

On Sun, Nov 14, 2021 at 04:42:18PM -0800, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
> 
> Fixes these build errors:
> 
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Suggested-by: Russell King (Oracle) <[e-mail]>
> Cc: Artur Rojek <[e-mail]>
> Cc: Paul Cercueil <[e-mail]>
> Cc: [e-mail]
> Cc: Jonathan Cameron <[e-mail]>
> Cc: Lars-Peter Clausen <[e-mail]>
> Cc: [e-mail]
> Cc: Florian Fainelli <[e-mail]>
> Cc: Andy Shevchenko <[e-mail]>
> Cc: Russell King <[e-mail]>
> Cc: [e-mail]
> Cc: Jonas Gorski <[e-mail]>
> Reviewed-by: Andy Shevchenko <[e-mail]>
> Acked-by: Jonathan Cameron <[e-mail]>
> Acked-by: Russell King (Oracle) <[e-mail]>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
>   (limiting this driver to MACH_INGENIC in Kconfig)
> v3: add clk_get_parent() to arch/mips/bcm63xx/clk.c
> v4:
>   add Fixes:, Suggested-by:, Reviewed-by: Acked-by:
>   drop blank line between function and EXPORT_SYMBOL(); (Andy)
> 
>  arch/mips/bcm63xx/clk.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,12 @@ void clk_disable(struct clk *clk)
>  
>  EXPORT_SYMBOL(clk_disable);
>  
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +	return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
>  unsigned long clk_get_rate(struct clk *clk)
>  {
>  	if (!clk)

applied to mips-fixes.

Thomas.

Patch

--- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
+++ linux-next-20211112/arch/mips/bcm63xx/clk.c
@@ -381,6 +381,12 @@  void clk_disable(struct clk *clk)
 
 EXPORT_SYMBOL(clk_disable);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
 unsigned long clk_get_rate(struct clk *clk)
 {
 	if (!clk)