| Message ID | 20211115153003.9140-4-arbn@yandex-team.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] vhost: get rid of vhost_poll_flush() wrapper | expand |
On Mon, Nov 15, 2021 at 06:30:01PM +0300, Andrey Ryabinin wrote: >vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) >before vhost_work_dev_flush(&vsock->dev). This seems pointless >as vsock->vqs[i].poll.dev is the same as &vsock->dev and several flushes >in a row doesn't do anything useful, one is just enough. > >Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com> >--- > drivers/vhost/vsock.c | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c >index b0361ebbd695..b4dcefbb7e60 100644 >--- a/drivers/vhost/vsock.c >+++ b/drivers/vhost/vsock.c >@@ -707,11 +707,6 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file) > > static void vhost_vsock_flush(struct vhost_vsock *vsock) > { >- int i; >- >- for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) >- if (vsock->vqs[i].handle_kick) >- vhost_work_dev_flush(vsock->vqs[i].poll.dev); > vhost_work_dev_flush(&vsock->dev); > } > >-- >2.32.0 > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index b0361ebbd695..b4dcefbb7e60 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsock.c @@ -707,11 +707,6 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file) static void vhost_vsock_flush(struct vhost_vsock *vsock) { - int i; - - for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) - if (vsock->vqs[i].handle_kick) - vhost_work_dev_flush(vsock->vqs[i].poll.dev); vhost_work_dev_flush(&vsock->dev); }
vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) before vhost_work_dev_flush(&vsock->dev). This seems pointless as vsock->vqs[i].poll.dev is the same as &vsock->dev and several flushes in a row doesn't do anything useful, one is just enough. Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com> --- drivers/vhost/vsock.c | 5 ----- 1 file changed, 5 deletions(-)