| Message ID | 20211117063955.160777-1-ye.guojin@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | virtio-blk: modify the value type of num in virtio_queue_rq() | expand |
On Wed, Nov 17, 2021 at 06:39:55AM +0000, cgel.zte@gmail.com wrote: >From: Ye Guojin <ye.guojin@zte.com.cn> > >This was found by coccicheck: >./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression >compared with zero num < 0 > We should add the Fixes tag: Fixes: 02746e26c39e ("virtio-blk: avoid preallocating big SGL for data") >Reported-by: Zeal Robot <zealci@zte.com.cn> >Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn> >--- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c >index 97bf051a50ce..eed1666eff31 100644 >--- a/drivers/block/virtio_blk.c >+++ b/drivers/block/virtio_blk.c >@@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(struct >blk_mq_hw_ctx *hctx, > struct request *req = bd->rq; > struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); > unsigned long flags; >- unsigned int num; >+ int num; > int qid = hctx->queue_num; > bool notify = false; > blk_status_t status; >-- >2.25.1 > The patch LGTM. With the Fixes tag added: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
On 11/17/2021 8:39 AM, cgel.zte@gmail.com wrote: > From: Ye Guojin <ye.guojin@zte.com.cn> > > This was found by coccicheck: > ./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression > compared with zero num < 0 > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn> > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 97bf051a50ce..eed1666eff31 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx, > struct request *req = bd->rq; > struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); > unsigned long flags; > - unsigned int num; > + int num; > int qid = hctx->queue_num; > bool notify = false; > blk_status_t status; Looks good, Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
On Wed, Nov 17, 2021 at 06:39:55AM +0000, cgel.zte@gmail.com wrote: > From: Ye Guojin <ye.guojin@zte.com.cn> > > This was found by coccicheck: > ./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression > compared with zero num < 0 > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn> > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 97bf051a50ce..eed1666eff31 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx, struct request *req = bd->rq; struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); unsigned long flags; - unsigned int num; + int num; int qid = hctx->queue_num; bool notify = false; blk_status_t status;