| Message ID | 20211114170335.66994-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | power-suppy/i2c/extcon: Fix charger setup on Xiaomi Mi Pad 2 and Lenovo Yogabook | expand |
On Sun, Nov 14, 2021 at 7:03 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > This is version 2 of my series previously titled: > "[PATCH 00/13] power-suppy/i2c/extcon: Add support for cht-wc PMIC > without USB-PD support". > > So far almost all the kernel code surrounding the Cherry Trail Whiskey Cove > PMIC has been developed on the GPD win / pocket devices and it has various > assumption based on that. In the mean time I've learned (and gotten access > to) about 2 more designs and none of the 3 now known designs use a single > standard setup for the charger, fuel-gauge and other chips surrounding the > PMIC / charging+data USB port: > > 1. The GPD Win and GPD Pocket mini-laptops, these are really 2 models > but the Pocket re-uses the GPD Win's design in a different housing: > > The WC PMIC is connected to a TI BQ24292i charger, paired with > a Maxim MAX17047 fuelgauge + a FUSB302 USB Type-C Controller + > a PI3USB30532 USB switch, for a fully functional Type-C port. > > 2. The Xiaomi Mi Pad 2: > > The WC PMIC is connected to a TI BQ25890 charger, paired with > a TI BQ27520 fuelgauge, using the TI BQ25890 for BC1.2 charger type > detection, for a USB-2 only Type-C port without PD. > > 3. The Lenovo Yoga Book YB1-X90 / Lenovo Yoga Book YB1-X91 series: > > The WC PMIC is connected to a TI BQ25892 charger, paired with > a TI BQ27542 fuelgauge, using the WC PMIC for BC1.2 charger type > detection and using the BQ25892's Mediatek Pump Express+ (1.0) > > ### > > Unlike what is normal on X86 this diversity in designs is not handled / > abstracted away by the ACPI tables. I will briefly look into it, right now two observations (or nit-picks): - you may utilize Co-developed-by tag when it makes sense - I would rather see "x86/ACPI" in all texts (note small "x")
Hi, On 11/16/21 12:00, Andy Shevchenko wrote: > On Sun, Nov 14, 2021 at 7:03 PM Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi All, >> >> This is version 2 of my series previously titled: >> "[PATCH 00/13] power-suppy/i2c/extcon: Add support for cht-wc PMIC >> without USB-PD support". >> >> So far almost all the kernel code surrounding the Cherry Trail Whiskey Cove >> PMIC has been developed on the GPD win / pocket devices and it has various >> assumption based on that. In the mean time I've learned (and gotten access >> to) about 2 more designs and none of the 3 now known designs use a single >> standard setup for the charger, fuel-gauge and other chips surrounding the >> PMIC / charging+data USB port: >> >> 1. The GPD Win and GPD Pocket mini-laptops, these are really 2 models >> but the Pocket re-uses the GPD Win's design in a different housing: >> >> The WC PMIC is connected to a TI BQ24292i charger, paired with >> a Maxim MAX17047 fuelgauge + a FUSB302 USB Type-C Controller + >> a PI3USB30532 USB switch, for a fully functional Type-C port. >> >> 2. The Xiaomi Mi Pad 2: >> >> The WC PMIC is connected to a TI BQ25890 charger, paired with >> a TI BQ27520 fuelgauge, using the TI BQ25890 for BC1.2 charger type >> detection, for a USB-2 only Type-C port without PD. >> >> 3. The Lenovo Yoga Book YB1-X90 / Lenovo Yoga Book YB1-X91 series: >> >> The WC PMIC is connected to a TI BQ25892 charger, paired with >> a TI BQ27542 fuelgauge, using the WC PMIC for BC1.2 charger type >> detection and using the BQ25892's Mediatek Pump Express+ (1.0) >> >> ### >> >> Unlike what is normal on X86 this diversity in designs is not handled / >> abstracted away by the ACPI tables. > > I will briefly look into it, right now two observations (or nit-picks): Thank you. > - you may utilize Co-developed-by tag when it makes sense Right, I intended to do so in patch 13/20, but I now see that I somehow forgot that :) > - I would rather see "x86/ACPI" in all texts (note small "x") Ack. Regards, Hans
Hi, On Sun, Nov 14, 2021 at 06:03:15PM +0100, Hans de Goede wrote: > This is version 2 of my series previously titled: > "[PATCH 00/13] power-suppy/i2c/extcon: Add support for cht-wc PMIC > without USB-PD support". [...] Apart from the already pointed out things the power-supply changes LGTM. -- Sebastian
Hi All, This is version 2 of my series previously titled: "[PATCH 00/13] power-suppy/i2c/extcon: Add support for cht-wc PMIC without USB-PD support". So far almost all the kernel code surrounding the Cherry Trail Whiskey Cove PMIC has been developed on the GPD win / pocket devices and it has various assumption based on that. In the mean time I've learned (and gotten access to) about 2 more designs and none of the 3 now known designs use a single standard setup for the charger, fuel-gauge and other chips surrounding the PMIC / charging+data USB port: 1. The GPD Win and GPD Pocket mini-laptops, these are really 2 models but the Pocket re-uses the GPD Win's design in a different housing: The WC PMIC is connected to a TI BQ24292i charger, paired with a Maxim MAX17047 fuelgauge + a FUSB302 USB Type-C Controller + a PI3USB30532 USB switch, for a fully functional Type-C port. 2. The Xiaomi Mi Pad 2: The WC PMIC is connected to a TI BQ25890 charger, paired with a TI BQ27520 fuelgauge, using the TI BQ25890 for BC1.2 charger type detection, for a USB-2 only Type-C port without PD. 3. The Lenovo Yoga Book YB1-X90 / Lenovo Yoga Book YB1-X91 series: The WC PMIC is connected to a TI BQ25892 charger, paired with a TI BQ27542 fuelgauge, using the WC PMIC for BC1.2 charger type detection and using the BQ25892's Mediatek Pump Express+ (1.0) ### Unlike what is normal on X86 this diversity in designs is not handled / abstracted away by the ACPI tables. This series takes care of making sure that charging and device/host mode switching also works on the Xiaomi Mi Pad 2 and the Lenovo Yogabook. New in version 2 of this patch-set: - This is all about Whiskey Cove based designs, instead of going roundabout and (ab)using drivers/platform/x86/touchscreen_dmi.c to add device-properties on the WC I2C-dev and then check for that, just add a new intel_cht_wc_get_model() helper to the intel_soc_pmic_chtwc.c MFD-driver. - Extend the series to not only fix things on the Mi Pad 2, but also on the Lenovo Yogabook YB1-X90*/-X91* models. Patches 1-13: Prepare the bq25890 power_supply driver to fully support the Mi Pad 2 and the Yogabook Note this includes a new version of the 3 bq25890 cleanup / fixes patches send earlier by Yauhen Kharuzhy Patch 14: Adds the intel_cht_wc_get_model() helper Patch 15: Uses this intel_cht_wc_get_model() value to instantiate an i2c-client with the right type and properties for the charger IC used on the board (instead of harcoding the GPD values) Patches 16-20: Modify the extcon code to provide charger-detection results to the charger driver and to take care of the Vbus boost regulator control (for host-mode) and device/host mode switching I've tried to keep the power_supply patches as generic as possible while focussing some of the special handling these boards need in the WC PMIC MFD and cell drivers, which will only get loaded on these boards. Since some of the later patches depend on some of the power_supply changes; and since the Whiskey Cove MFD and cell drivers generally do not see much changes I believe that it would be best to merge the entire series through Sebastian's linux-power-supply tree. Lee, Wolfram and Chanwoo, may we please have your Ack for merging this entire series through Sebastian's linux-power-supply tree? Regards, Hans Hans de Goede (16): power: supply: core: Refactor power_supply_set_input_current_limit_from_supplier() power: supply: bq25890: Add a bq25890_rw_init_data() helper power: supply: bq25890: Add support to skip reset at probe() / remove() power: supply: bq25890: Add support to read back the settings from the chip power: supply: bq25890: Enable charging on boards where we skip reset power: supply: bq25890: Drop dev->platform_data == NULL check power: supply: bq25890: Add bq25890_set_otg_cfg() helper power: supply: bq25890: Add support for registering the Vbus boost converter as a regulator power: supply: bq25890: On the bq25892 set the IINLIM based on external charger detection mfd: intel_soc_pmic_chtwc: Add intel_cht_wc_get_model() helper function i2c: cht-wc: Make charger i2c-client instantiation board/device-model specific extcon: intel-cht-wc: Use new intel_cht_wc_get_model() helper extcon: intel-cht-wc: Support devs with Micro-B / USB-2 only Type-C connectors extcon: intel-cht-wc: Refactor cht_wc_extcon_get_charger() extcon: intel-cht-wc: Add support for registering a power_supply class-device extcon: intel-cht-wc: Report RID_A for ACA adapters Yauhen Kharuzhy (4): power: supply: bq25890: Fix ADC continuous conversion setting when charging power: supply: bq25890: Rename IILIM field to IINLIM power: supply: bq25890: Reduce reported CONSTANT_CHARGE_CURRENT_MAX for low temperatures power: supply: bq25890: Support higher charging voltages through Pump Express+ protocol drivers/extcon/Kconfig | 3 +- drivers/extcon/extcon-intel-cht-wc.c | 242 +++++++++++++-- drivers/i2c/busses/i2c-cht-wc.c | 120 ++++++-- drivers/mfd/intel_soc_pmic_chtwc.c | 46 +++ drivers/power/supply/bq24190_charger.c | 10 +- drivers/power/supply/bq25890_charger.c | 374 +++++++++++++++++++---- drivers/power/supply/power_supply_core.c | 57 ++-- include/linux/mfd/intel_soc_pmic.h | 9 + include/linux/power/bq25890_charger.h | 15 + include/linux/power_supply.h | 5 +- 10 files changed, 744 insertions(+), 137 deletions(-) create mode 100644 include/linux/power/bq25890_charger.h