| Message ID | 20211110092942.1648429-1-robin@jarry.cc (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 91039a781e16b6d0e7d20f8550b0a89ac17419f4 |
| Headers | show |
| Series | [v3] receive-pack: ignore SIGPIPE while reporting status to client | expand |
Hi, did you get a chance to look at v3? Were there additional remarks? Thanks.
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index 49b846d96052..2f4a38adfe2c 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -2566,10 +2566,12 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix) &push_options); if (pack_lockfile) unlink_or_warn(pack_lockfile); + sigchain_push(SIGPIPE, SIG_IGN); if (report_status_v2) report_v2(commands, unpack_status); else if (report_status) report(commands, unpack_status); + sigchain_pop(SIGPIPE); run_receive_hook(commands, "post-receive", 1, &push_options); run_update_post_hook(commands);
Before running the post-receive hook, status info is reported back to the client. If a remote client exits before or during the status report, receive-pack is killed by SIGPIPE and post-receive is never executed. The post-receive hook is often used to send email notifications (see contrib/hooks/post-receive-email), update bug trackers, start automatic builds, etc. Not executing it after an interrupted yet "successful" push can lead to inconsistencies. Ignore SIGPIPE before reporting status to the client to increase the chances of post-receive running if pre-receive was successful. This does not guarantee 100% consistency but it should resist early disconnection by the client. Signed-off-by: Robin Jarry <robin@jarry.cc> --- Changes since v2: * Updated commit log with more pertinent info. * Only ignore SIGPIPE while reporting status, *after* removing the lock file. builtin/receive-pack.c | 2 ++ 1 file changed, 2 insertions(+)