| Message ID | 20211111031635.3839947-1-danct12@riseup.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | Improve support for Xiaomi Redmi Note 7 | expand |
Hi Dang, On 2021-11-11 10:16:27, Dang Huynh wrote: > This series expand the Redmi Note 7 device port to support: > + Regulators > + Volume keys > + eMMC and SD card slot > + Framebuffer display > + USB > > Changes in v2: > - Dropped linux,input-type from volume up as 1 is set by default. > - Dropped gpio-key,wakeup as it's a legacy property name and is > not relevant for a volume button. > - Rename label cont_splash_mem to framebuffer_mem and change node > name to memory. > > Changes in v3: > - Add voltage range for vph_pwr > - Move RESIN to PM660 and make PON keys disabled by default > - Addressed review comments from Konrad A bit of a formality: keep in mind that you cannot add Reviewed-by: to patches unless explicitly given by the reviewer. They do not represent that a person has at some point given you a review on the patch; rather they indicate that the reviewer in question has checked and agreed with the changes. In other words, after Konrad has reviewed your patches you should resend a fixed version without his Reviewed-by:. He'll reply with this line once he has seen and acknowledged the resulting changes (or otherwise reply with more requests for changes). The maintainer picks these up when applying the patchset to the tree, but you should pick them up yourself if/when resending a new version. Finally, this is a bit tricky but you should technically drop every Reviewed-by: whenever a patch is changed in a followup patchset, leaving it up to the reviewers to acknowledge that they are also okay with the updated patch. - Marijn > - Make Alexey Min the author of the USB patch as he came up with > the patch first on downstream. > > Alexey Min (1): > arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB > > Dang Huynh (7): > arm64: dts: qcom: sdm630: Assign numbers to eMMC and SD > arm64: dts: qcom: sdm630-pm660: Move RESIN to pm660 dtsi > arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators > arm64: dts: qcom: sdm660-xiaomi-lavender: Add PWRKEY and RESIN > arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button > arm64: dts: qcom: sdm660-xiaomi-lavender: Add eMMC and SD > arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer > > arch/arm64/boot/dts/qcom/pm660.dtsi | 12 +- > .../dts/qcom/sdm630-sony-xperia-nile.dtsi | 16 +- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 5 + > .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 383 ++++++++++++++++++ > 4 files changed, 407 insertions(+), 9 deletions(-) > > -- > 2.33.1 >
On Wed 10 Nov 21:16 CST 2021, Dang Huynh wrote: > This series expand the Redmi Note 7 device port to support: > + Regulators > + Volume keys > + eMMC and SD card slot > + Framebuffer display > + USB > Thanks for the patches Dang, I think they look good and would like to merge them. Could you please submit an updated version with the one gpio.h inclusion pointed out by Konrad moved and fix up the Reviewed-by pointed out my Martin? Thanks, Bjorn > Changes in v2: > - Dropped linux,input-type from volume up as 1 is set by default. > - Dropped gpio-key,wakeup as it's a legacy property name and is > not relevant for a volume button. > - Rename label cont_splash_mem to framebuffer_mem and change node > name to memory. > > Changes in v3: > - Add voltage range for vph_pwr > - Move RESIN to PM660 and make PON keys disabled by default > - Addressed review comments from Konrad > - Make Alexey Min the author of the USB patch as he came up with > the patch first on downstream. > > Alexey Min (1): > arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB > > Dang Huynh (7): > arm64: dts: qcom: sdm630: Assign numbers to eMMC and SD > arm64: dts: qcom: sdm630-pm660: Move RESIN to pm660 dtsi > arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators > arm64: dts: qcom: sdm660-xiaomi-lavender: Add PWRKEY and RESIN > arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button > arm64: dts: qcom: sdm660-xiaomi-lavender: Add eMMC and SD > arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer > > arch/arm64/boot/dts/qcom/pm660.dtsi | 12 +- > .../dts/qcom/sdm630-sony-xperia-nile.dtsi | 16 +- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 5 + > .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 383 ++++++++++++++++++ > 4 files changed, 407 insertions(+), 9 deletions(-) > > -- > 2.33.1 >