| Message ID | 20211122153233.9924-4-mhocko@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | extend vmalloc support for constrained allocations | expand |
On Mon, Nov 22, 2021 at 04:32:32PM +0100, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > b7d90e7a5ea8 ("mm/vmalloc: be more explicit about supported gfp flags") > has been merged prematurely without the rest of the series and without > addressed review feedback from Neil. Fix that up now. Only wording is > changed slightly. > > Signed-off-by: Michal Hocko <mhocko@suse.com> > --- > mm/vmalloc.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index b6aed4f94a85..b1c115ec13be 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3021,12 +3021,14 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > * > * Allocate enough pages to cover @size from the page level > * allocator with @gfp_mask flags. Please note that the full set of gfp > - * flags are not supported. GFP_KERNEL would be a preferred allocation mode > - * but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not > - * supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka > - * GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka > - * __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported). > - * __GFP_NOWARN can be used to suppress error messages about failures. > + * flags are not supported. GFP_KERNEL, GFP_NOFS and GFP_NOIO are all > + * supported. > + * Zone modifiers are not supported. From the reclaim modifiers > + * __GFP_DIRECT_RECLAIM is required (aka GFP_NOWAIT is not supported) > + * and only __GFP_NOFAIL is supported (i.e. __GFP_NORETRY and > + * __GFP_RETRY_MAYFAIL are not supported). > + * > + * __GFP_NOWARN can be used to suppress failures messages. > * > * Map them into contiguous kernel virtual space, using a pagetable > * protection of @prot. > -- > 2.30.2 > Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com> -- Vlad Rezki
On 11/22/21 16:32, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > b7d90e7a5ea8 ("mm/vmalloc: be more explicit about supported gfp flags") > has been merged prematurely without the rest of the series and without > addressed review feedback from Neil. Fix that up now. Only wording is > changed slightly. > > Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/vmalloc.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index b6aed4f94a85..b1c115ec13be 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3021,12 +3021,14 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > * > * Allocate enough pages to cover @size from the page level > * allocator with @gfp_mask flags. Please note that the full set of gfp > - * flags are not supported. GFP_KERNEL would be a preferred allocation mode > - * but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not > - * supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka > - * GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka > - * __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported). > - * __GFP_NOWARN can be used to suppress error messages about failures. > + * flags are not supported. GFP_KERNEL, GFP_NOFS and GFP_NOIO are all > + * supported. > + * Zone modifiers are not supported. From the reclaim modifiers > + * __GFP_DIRECT_RECLAIM is required (aka GFP_NOWAIT is not supported) > + * and only __GFP_NOFAIL is supported (i.e. __GFP_NORETRY and > + * __GFP_RETRY_MAYFAIL are not supported). > + * > + * __GFP_NOWARN can be used to suppress failures messages. > * > * Map them into contiguous kernel virtual space, using a pagetable > * protection of @prot. >
diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b6aed4f94a85..b1c115ec13be 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3021,12 +3021,14 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, * * Allocate enough pages to cover @size from the page level * allocator with @gfp_mask flags. Please note that the full set of gfp - * flags are not supported. GFP_KERNEL would be a preferred allocation mode - * but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not - * supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka - * GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka - * __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported). - * __GFP_NOWARN can be used to suppress error messages about failures. + * flags are not supported. GFP_KERNEL, GFP_NOFS and GFP_NOIO are all + * supported. + * Zone modifiers are not supported. From the reclaim modifiers + * __GFP_DIRECT_RECLAIM is required (aka GFP_NOWAIT is not supported) + * and only __GFP_NOFAIL is supported (i.e. __GFP_NORETRY and + * __GFP_RETRY_MAYFAIL are not supported). + * + * __GFP_NOWARN can be used to suppress failures messages. * * Map them into contiguous kernel virtual space, using a pagetable * protection of @prot.