| Message ID | f97179a630e7d0fc739a118e2b321e1a6432876b.1637691240.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: JZ4780 and CI20 HDMI | expand |
On Tue, 23 Nov 2021 19:13:56 +0100, H. Nikolaus Schaller wrote: > From: Sam Ravnborg <sam@ravnborg.org> > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel > > We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > --- > .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 +++++++++++++++++++ > .../display/bridge/synopsys,dw-hdmi.yaml | 3 + > 2 files changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: 'unevaluatedPropertes' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select'] from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: A schema with a "$ref" to another schema either can define all properties used and use "additionalProperties" or can use "unevaluatedProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/bridge/bridge/synopsys,dw-hdmi.yaml' xargs: dt-doc-validate: exited with status 255; aborting /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.example.dts:19:18: fatal error: dt-bindings/clock/jz4780-cgu.h: No such file or directory 19 | #include <dt-bindings/clock/jz4780-cgu.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1413: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1558736 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Nikolaus, Le mar., nov. 23 2021 at 19:13:56 +0100, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > From: Sam Ravnborg <sam@ravnborg.org> > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel > > We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > --- > .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 > +++++++++++++++++++ > .../display/bridge/synopsys,dw-hdmi.yaml | 3 + > 2 files changed, 79 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > > diff --git > a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > new file mode 100644 > index 0000000000000..190ca4521b1d0 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bridge/ingenic,jz4780-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Ingenic JZ4780 HDMI Transmitter > + > +maintainers: > + - H. Nikolaus Schaller <hns@goldelico.com> > + > +description: | > + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys > DesignWare HDMI 1.4 > + TX controller IP with accompanying PHY IP. > + > +allOf: > + - $ref: bridge/synopsys,dw-hdmi.yaml# > + > +properties: > + compatible: > + const: ingenic,jz4780-dw-hdmi > + > + reg-io-width: > + const: 4 > + > + clocks: > + maxItems: 2 > + > + hdmi-5v-supply: > + description: Optional regulator to provide +5V at the connector > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > +required: > + - compatible > + - clocks > + - clock-names > + - ports > + - reg-io-width > + > +unevaluatedPropertes: false > + > +examples: > + - | > + #include <dt-bindings/clock/jz4780-cgu.h> This include was moved in 5.16-rc1 to <dt-bindings/clock/ingenic,jz4780-cgu.h>. Cheers, -Paul > + > + hdmi: hdmi@10180000 { > + compatible = "ingenic,jz4780-dw-hdmi"; > + reg = <0x10180000 0x8000>; > + reg-io-width = <4>; > + ddc-i2c-bus = <&i2c4>; > + interrupt-parent = <&intc>; > + interrupts = <3>; > + clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>; > + clock-names = "iahb", "isfr"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + hdmi_in: port@0 { > + reg = <0>; > + dw_hdmi_in: endpoint { > + remote-endpoint = <&jz4780_lcd_out>; > + }; > + }; > + hdmi_out: port@1 { > + reg = <1>; > + dw_hdmi_out: endpoint { > + remote-endpoint = <&hdmi_con>; > + }; > + }; > + }; > + }; > + > +... > diff --git > a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > index 9be44a682e67a..9cbeabaee0968 100644 > --- > a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > +++ > b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > @@ -50,6 +50,9 @@ properties: > interrupts: > maxItems: 1 > > + ddc-i2c-bus: > + description: An I2C interface if the internal DDC I2C driver is > not to be used > + > additionalProperties: true > > ... > -- > 2.33.0 >
Hi Rob and Paul, > Am 24.11.2021 um 10:17 schrieb Paul Cercueil <paul@crapouillou.net>: > > Hi Nikolaus, > > Le mar., nov. 23 2021 at 19:13:56 +0100, H. Nikolaus Schaller <hns@goldelico.com> a écrit : >> From: Sam Ravnborg <sam@ravnborg.org> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> --- >> .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 +++++++++++++++++++ >> .../display/bridge/synopsys,dw-hdmi.yaml | 3 + >> 2 files changed, 79 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml >> diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml >> new file mode 100644 >> index 0000000000000..190ca4521b1d0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml >> @@ -0,0 +1,76 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/bridge/ingenic,jz4780-hdmi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for Ingenic JZ4780 HDMI Transmitter >> + >> +maintainers: >> + - H. Nikolaus Schaller <hns@goldelico.com> >> + >> +description: | >> + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 >> + TX controller IP with accompanying PHY IP. >> + >> +allOf: >> + - $ref: bridge/synopsys,dw-hdmi.yaml# >> + >> +properties: >> + compatible: >> + const: ingenic,jz4780-dw-hdmi >> + >> + reg-io-width: >> + const: 4 >> + >> + clocks: >> + maxItems: 2 >> + >> + hdmi-5v-supply: >> + description: Optional regulator to provide +5V at the connector >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - ports >> + - reg-io-width >> + >> +unevaluatedPropertes: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/jz4780-cgu.h> > > This include was moved in 5.16-rc1 to <dt-bindings/clock/ingenic,jz4780-cgu.h>. I see! > > Cheers, > -Paul > >> + >> + hdmi: hdmi@10180000 { >> + compatible = "ingenic,jz4780-dw-hdmi"; >> + reg = <0x10180000 0x8000>; >> + reg-io-width = <4>; >> + ddc-i2c-bus = <&i2c4>; >> + interrupt-parent = <&intc>; >> + interrupts = <3>; >> + clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>; >> + clock-names = "iahb", "isfr"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + hdmi_in: port@0 { >> + reg = <0>; >> + dw_hdmi_in: endpoint { >> + remote-endpoint = <&jz4780_lcd_out>; >> + }; >> + }; >> + hdmi_out: port@1 { >> + reg = <1>; >> + dw_hdmi_out: endpoint { >> + remote-endpoint = <&hdmi_con>; >> + }; >> + }; >> + }; >> + }; >> + >> +... >> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> index 9be44a682e67a..9cbeabaee0968 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> @@ -50,6 +50,9 @@ properties: >> interrupts: >> maxItems: 1 >> + ddc-i2c-bus: >> + description: An I2C interface if the internal DDC I2C driver is not to be used >> + >> additionalProperties: true >> ... >> -- >> 2.33.0 > >
> Am 24.11.2021 um 03:59 schrieb Rob Herring <robh@kernel.org>: > > On Tue, 23 Nov 2021 19:13:56 +0100, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg <sam@ravnborg.org> >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml >> >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> --- >> .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 +++++++++++++++++++ >> .../display/bridge/synopsys,dw-hdmi.yaml | 3 + >> 2 files changed, 79 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation) ok, fixed. > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: 'unevaluatedPropertes' is not one of ['$id', '$schema', 'title', 'description', 'examples', ah, that is a typo (missing i in ...ties). > 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select'] > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > hint: A schema with a "$ref" to another schema either can define all properties used and use "additionalProperties" or can use "unevaluatedProperties" > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/bridge/bridge/synopsys,dw-hdmi.yaml' > xargs: dt-doc-validate: exited with status 255; aborting > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml: ignoring, error in schema: > warning: no schema found in file: ./Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml > Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.example.dts:19:18: fatal error: dt-bindings/clock/jz4780-cgu.h: No such file or directory > 19 | #include <dt-bindings/clock/jz4780-cgu.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1413: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1558736 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml new file mode 100644 index 0000000000000..190ca4521b1d0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bridge/ingenic,jz4780-hdmi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bindings for Ingenic JZ4780 HDMI Transmitter + +maintainers: + - H. Nikolaus Schaller <hns@goldelico.com> + +description: | + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 + TX controller IP with accompanying PHY IP. + +allOf: + - $ref: bridge/synopsys,dw-hdmi.yaml# + +properties: + compatible: + const: ingenic,jz4780-dw-hdmi + + reg-io-width: + const: 4 + + clocks: + maxItems: 2 + + hdmi-5v-supply: + description: Optional regulator to provide +5V at the connector + + ports: + $ref: /schemas/graph.yaml#/properties/ports + +required: + - compatible + - clocks + - clock-names + - ports + - reg-io-width + +unevaluatedPropertes: false + +examples: + - | + #include <dt-bindings/clock/jz4780-cgu.h> + + hdmi: hdmi@10180000 { + compatible = "ingenic,jz4780-dw-hdmi"; + reg = <0x10180000 0x8000>; + reg-io-width = <4>; + ddc-i2c-bus = <&i2c4>; + interrupt-parent = <&intc>; + interrupts = <3>; + clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>; + clock-names = "iahb", "isfr"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + hdmi_in: port@0 { + reg = <0>; + dw_hdmi_in: endpoint { + remote-endpoint = <&jz4780_lcd_out>; + }; + }; + hdmi_out: port@1 { + reg = <1>; + dw_hdmi_out: endpoint { + remote-endpoint = <&hdmi_con>; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml index 9be44a682e67a..9cbeabaee0968 100644 --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml @@ -50,6 +50,9 @@ properties: interrupts: maxItems: 1 + ddc-i2c-bus: + description: An I2C interface if the internal DDC I2C driver is not to be used + additionalProperties: true ...