| Message ID | 20211126180101.27818-23-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Introduce power-off+restart call chain API | expand |
On Fri, Nov 26, 2021 at 09:00:58PM +0300, Dmitry Osipenko wrote: > Replace legacy pm_power_off with kernel_can_power_off() helper that > is aware about chained power-off handlers. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/memory/emif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c > index 762d0c0f0716..cab10d5274a0 100644 > --- a/drivers/memory/emif.c > +++ b/drivers/memory/emif.c > @@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id) > dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n"); > > /* If we have Power OFF ability, use it, else try restarting */ > - if (pm_power_off) { > + if (kernel_can_power_off()) { > kernel_power_off(); > } else { > WARN(1, "FIXME: NO pm_power_off!!! trying restart\n"); BTW, this part of the code seems to be better moved to generic code that could replace POWER_OFF request with REBOOT like it is done for reboot() syscall. Best Regards Michał Mirosław
28.11.2021 04:23, Michał Mirosław пишет: > On Fri, Nov 26, 2021 at 09:00:58PM +0300, Dmitry Osipenko wrote: >> Replace legacy pm_power_off with kernel_can_power_off() helper that >> is aware about chained power-off handlers. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> drivers/memory/emif.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c >> index 762d0c0f0716..cab10d5274a0 100644 >> --- a/drivers/memory/emif.c >> +++ b/drivers/memory/emif.c >> @@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id) >> dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n"); >> >> /* If we have Power OFF ability, use it, else try restarting */ >> - if (pm_power_off) { >> + if (kernel_can_power_off()) { >> kernel_power_off(); >> } else { >> WARN(1, "FIXME: NO pm_power_off!!! trying restart\n"); > > BTW, this part of the code seems to be better moved to generic code that > could replace POWER_OFF request with REBOOT like it is done for reboot() > syscall. Not sure that it can be done. Somebody will have to verify that it won't break all those platform power-off handlers. Better to keep this code as-is in the context of this patchset.
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 762d0c0f0716..cab10d5274a0 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id) dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n"); /* If we have Power OFF ability, use it, else try restarting */ - if (pm_power_off) { + if (kernel_can_power_off()) { kernel_power_off(); } else { WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
Replace legacy pm_power_off with kernel_can_power_off() helper that is aware about chained power-off handlers. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/memory/emif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)