[0/5] ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method

Message

Kuninori Morimoto Nov. 16, 2021, 7:44 a.m. UTC

Hi Mark

Current soc_pcm_pointer() is checking runtime->delay,
but it might be updated silently by component's .point callback.
It is strange and difficult to find/know the issue.

This patch adds .delay callback for component, and solve the issue.

Kuninori Morimoto (5):
  ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay()
  ASoC: soc-component: add snd_soc_pcm_component_delay()
  ASoC: amd: acp-pcm-dma: add .delay support
  ASoC: intel: sst-mfld-platform-pcm: add .delay support
  ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method

 include/sound/soc-component.h                |  4 ++
 include/sound/soc-dai.h                      |  4 +-
 sound/soc/amd/acp-pcm-dma.c                  | 15 +++++++-
 sound/soc/amd/acp.h                          |  1 +
 sound/soc/intel/atom/sst-mfld-platform-pcm.c | 14 ++++++-
 sound/soc/soc-component.c                    | 28 ++++++++++++++
 sound/soc/soc-dai.c                          | 40 ++++++++++++++------
 sound/soc/soc-pcm.c                          | 29 +++-----------
 8 files changed, 95 insertions(+), 40 deletions(-)

Comments

Pierre-Louis Bossart Nov. 29, 2021, 3:43 p.m. UTC | #1

> Current soc_pcm_pointer() is checking runtime->delay,
> but it might be updated silently by component's .point callback.
> It is strange and difficult to find/know the issue.
> 
> This patch adds .delay callback for component, and solve the issue.
> 
> Kuninori Morimoto (5):
>   ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay()
>   ASoC: soc-component: add snd_soc_pcm_component_delay()
>   ASoC: amd: acp-pcm-dma: add .delay support
>   ASoC: intel: sst-mfld-platform-pcm: add .delay support
>   ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method

For the series:

Reviewed-by: Pierre-Louis Bossart <[e-mail]>

Mark Brown Nov. 29, 2021, 4:45 p.m. UTC | #2

On 16 Nov 2021 16:44:50 +0900, Kuninori Morimoto wrote:
> Current soc_pcm_pointer() is checking runtime->delay,
> but it might be updated silently by component's .point callback.
> It is strange and difficult to find/know the issue.
> 
> This patch adds .delay callback for component, and solve the issue.
> 
> Kuninori Morimoto (5):
>   ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay()
>   ASoC: soc-component: add snd_soc_pcm_component_delay()
>   ASoC: amd: acp-pcm-dma: add .delay support
>   ASoC: intel: sst-mfld-platform-pcm: add .delay support
>   ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay()
      commit: 8544f08c816292c2219f28c6eaa69236b978bfb9
[2/5] ASoC: soc-component: add snd_soc_pcm_component_delay()
      commit: 403f830e7a0be5a9e33c7a9d208574f79887ec57
[3/5] ASoC: amd: acp-pcm-dma: add .delay support
      commit: feea640aaf1a5ae9dff6e33931e680542432e8dd
[4/5] ASoC: intel: sst-mfld-platform-pcm: add .delay support
      commit: 796b64a72db0b416f0aa1815e87aa28388b4715d
[5/5] ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method
      commit: 7be10cef0fbe91f83c55faea7e8b70c0529dde5f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark