| Message ID | 20211118210210.160895-2-luca@z3ntu.xyz (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 | expand |
Hi, On Thu, Nov 18, 2021 at 10:02:05PM +0100, Luca Weiss wrote: > PM8226 (used in MSM8226) has v1 smbb hardware and works fine with the > current driver. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- Thanks, queued. -- Sebastian > drivers/power/supply/qcom_smbb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c > index 84cc9fba029d..bd50124eef9f 100644 > --- a/drivers/power/supply/qcom_smbb.c > +++ b/drivers/power/supply/qcom_smbb.c > @@ -863,8 +863,8 @@ static int smbb_charger_probe(struct platform_device *pdev) > } > > chg->revision += 1; > - if (chg->revision != 2 && chg->revision != 3) { > - dev_err(&pdev->dev, "v1 hardware not supported\n"); > + if (chg->revision != 1 && chg->revision != 2 && chg->revision != 3) { > + dev_err(&pdev->dev, "v%d hardware not supported\n", chg->revision); > return -ENODEV; > } > dev_info(&pdev->dev, "Initializing SMBB rev %u", chg->revision); > @@ -1012,6 +1012,7 @@ static int smbb_charger_remove(struct platform_device *pdev) > } > > static const struct of_device_id smbb_charger_id_table[] = { > + { .compatible = "qcom,pm8226-charger" }, > { .compatible = "qcom,pm8941-charger" }, > { } > }; > -- > 2.34.0 >
diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c index 84cc9fba029d..bd50124eef9f 100644 --- a/drivers/power/supply/qcom_smbb.c +++ b/drivers/power/supply/qcom_smbb.c @@ -863,8 +863,8 @@ static int smbb_charger_probe(struct platform_device *pdev) } chg->revision += 1; - if (chg->revision != 2 && chg->revision != 3) { - dev_err(&pdev->dev, "v1 hardware not supported\n"); + if (chg->revision != 1 && chg->revision != 2 && chg->revision != 3) { + dev_err(&pdev->dev, "v%d hardware not supported\n", chg->revision); return -ENODEV; } dev_info(&pdev->dev, "Initializing SMBB rev %u", chg->revision); @@ -1012,6 +1012,7 @@ static int smbb_charger_remove(struct platform_device *pdev) } static const struct of_device_id smbb_charger_id_table[] = { + { .compatible = "qcom,pm8226-charger" }, { .compatible = "qcom,pm8941-charger" }, { } };
PM8226 (used in MSM8226) has v1 smbb hardware and works fine with the current driver. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- drivers/power/supply/qcom_smbb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)