| Message ID | 20211201071500.28648-2-tangyizhou@huawei.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | cpufreq: Update function comment and document | expand |
On 01-12-21, 15:14, Tang Yizhou wrote: > Comment both when CPUFREQ_CREATE_POLICY and CPUFREQ_REMOVE_POLICY > notification are sent. > > Signed-off-by: Tang Yizhou <tangyizhou@huawei.com> > --- > drivers/cpufreq/cpufreq.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index e338d2f010fe..e76777881739 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1296,8 +1296,9 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) > > if (policy->max_freq_req) { > /* > - * CPUFREQ_CREATE_POLICY notification is sent only after > - * successfully adding max_freq_req request. > + * Need to send CPUFREQ_REMOVE_POLICY notification if > + * max_freq_req request is successfully added. > + * See also: CPUFREQ_CREATE_POLICY notification. I will rather write this as: /* * Remove max_freq_req after sending CPUFREQ_REMOVE_POLICY * notification, since CPUFREQ_CREATE_POLICY notification was * sent after adding max_freq_req earlier. */ > */ > blocking_notifier_call_chain(&cpufreq_policy_notifier_list, > CPUFREQ_REMOVE_POLICY, policy); > @@ -1429,6 +1430,10 @@ static int cpufreq_online(unsigned int cpu) > goto out_destroy_policy; > } > > + /* > + * CPUFREQ_CREATE_POLICY notification is sent only after > + * successfully adding max_freq_req request. > + */ This is obvious, we don't need a comment here. > blocking_notifier_call_chain(&cpufreq_policy_notifier_list, > CPUFREQ_CREATE_POLICY, policy); > } > -- > 2.17.1
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index e338d2f010fe..e76777881739 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1296,8 +1296,9 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) if (policy->max_freq_req) { /* - * CPUFREQ_CREATE_POLICY notification is sent only after - * successfully adding max_freq_req request. + * Need to send CPUFREQ_REMOVE_POLICY notification if + * max_freq_req request is successfully added. + * See also: CPUFREQ_CREATE_POLICY notification. */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_REMOVE_POLICY, policy); @@ -1429,6 +1430,10 @@ static int cpufreq_online(unsigned int cpu) goto out_destroy_policy; } + /* + * CPUFREQ_CREATE_POLICY notification is sent only after + * successfully adding max_freq_req request. + */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_CREATE_POLICY, policy); }
Comment both when CPUFREQ_CREATE_POLICY and CPUFREQ_REMOVE_POLICY notification are sent. Signed-off-by: Tang Yizhou <tangyizhou@huawei.com> --- drivers/cpufreq/cpufreq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)