diff mbox series

PM: AVS: Use div64_ul instead of do_div

Message ID 20211125014311.45942-1-deng.changcheng@zte.com.cn (mailing list archive)
State Accepted
Headers show
Series PM: AVS: Use div64_ul instead of do_div | expand

Commit Message

CGEL Nov. 25, 2021, 1:43 a.m. UTC 
From: Changcheng Deng <deng.changcheng@zte.com.cn>

do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/soc/qcom/cpr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Andersson Dec. 1, 2021, 3:12 p.m. UTC | #1 
On Thu, 25 Nov 2021 01:43:11 +0000, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation.
> 
> 
> [...]

Applied, thanks!

[1/1] PM: AVS: Use div64_ul instead of do_div
      commit: e07a98b28decb21f7bdbcb05bf2acc58ea03b1e4

Best regards,
diff mbox series

Patch

diff --git a/drivers/soc/qcom/cpr.c b/drivers/soc/qcom/cpr.c
index 1d818a8ba208..e9b854ed1bdf 100644
--- a/drivers/soc/qcom/cpr.c
+++ b/drivers/soc/qcom/cpr.c
@@ -1010,7 +1010,7 @@  static int cpr_interpolate(const struct corner *corner, int step_volt,
 		return corner->uV;
 
 	temp = f_diff * (uV_high - uV_low);
-	do_div(temp, f_high - f_low);
+	temp = div64_ul(temp, f_high - f_low);
 
 	/*
 	 * max_volt_scale has units of uV/MHz while freq values